Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should use errors.AsErr to extract and detect errors.Error #1936

Merged
merged 1 commit into from
Apr 9, 2024
Merged

should use errors.AsErr to extract and detect errors.Error #1936

merged 1 commit into from
Apr 9, 2024

Conversation

kkHAIKE
Copy link
Contributor

@kkHAIKE kkHAIKE commented Apr 8, 2024

What is the problem I am trying to address?

When outputting JSON logs, there are no additional fields.
截屏2024-04-09 10 59 56

How is the fix applied?

Output that fields

截屏2024-04-09 11 01 55

What GitHub issue(s) does this PR fix or close?

Fixes #

@kkHAIKE kkHAIKE requested a review from a team as a code owner April 8, 2024 11:55
@matt0x6F
Copy link
Contributor

matt0x6F commented Apr 8, 2024

@kkHAIKE thanks for your contribution! Can you give me an example of what output looked like before versus after your proposed change?

@matt0x6F matt0x6F added the on hold Issues and pull requests that shouldn't be closed yet, but shouldn't be worked on yet either label Apr 8, 2024
@kkHAIKE
Copy link
Contributor Author

kkHAIKE commented Apr 9, 2024

@kkHAIKE thanks for your contribution! Can you give me an example of what output looked like before versus after your proposed change?

This is considered a relatively basic mistake; if you use errors.IsErr, the variable used in the call errFields function parameter will always be empty.

athens/pkg/log/entry.go

Lines 38 to 44 in a32e5f0

var athensErr errors.Error
if !errors.IsErr(err, athensErr) {
e.Error(err)
return
}
ent := e.WithFields(errFields(athensErr))

@matt0x6F matt0x6F added bug Something isn't working and removed on hold Issues and pull requests that shouldn't be closed yet, but shouldn't be worked on yet either labels Apr 9, 2024
@matt0x6F matt0x6F added this to the 0.13.3 milestone Apr 9, 2024
@matt0x6F matt0x6F merged commit a5277a3 into gomods:main Apr 9, 2024
11 checks passed
DrPsychick referenced this pull request in gomods/athens-charts Apr 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gomods/athens](https://github.com/gomods/athens) | patch |
`v0.13.1` -> `v0.13.3` |

---

### Release Notes

<details>
<summary>gomods/athens (gomods/athens)</summary>

### [`v0.13.3`](https://github.com/gomods/athens/releases/tag/v0.13.3)

[Compare
Source](https://github.com/gomods/athens/compare/v0.13.2...v0.13.3)

#### What's Changed

- Update README.md by
[@&#8203;computerscienceiscool](https://github.com/computerscienceiscool)
in
[https://github.com/gomods/athens/pull/1932](https://github.com/gomods/athens/pull/1932)
- update-go-pkg(deps): bump github.com/stretchr/testify from 1.8.4 to
1.9.0 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1933](https://github.com/gomods/athens/pull/1933)
- Upgrade logrus from 1.7.0 => 1.9.3 by
[@&#8203;matt0x6F](https://github.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1934](https://github.com/gomods/athens/pull/1934)
- should use errors.AsErr to extract and detect errors.Error by
[@&#8203;kkHAIKE](https://github.com/kkHAIKE) in
[https://github.com/gomods/athens/pull/1936](https://github.com/gomods/athens/pull/1936)
- correcting the misuse of the context in the copyContextWithCustomTime…
by [@&#8203;kkHAIKE](https://github.com/kkHAIKE) in
[https://github.com/gomods/athens/pull/1941](https://github.com/gomods/athens/pull/1941)
- remove hardcoded rootPath values by
[@&#8203;Jeansen](https://github.com/Jeansen) in
[https://github.com/gomods/athens/pull/1874](https://github.com/gomods/athens/pull/1874)

#### New Contributors

-
[@&#8203;computerscienceiscool](https://github.com/computerscienceiscool)
made their first contribution in
[https://github.com/gomods/athens/pull/1932](https://github.com/gomods/athens/pull/1932)
- [@&#8203;kkHAIKE](https://github.com/kkHAIKE) made their first
contribution in
[https://github.com/gomods/athens/pull/1936](https://github.com/gomods/athens/pull/1936)
- [@&#8203;Jeansen](https://github.com/Jeansen) made their first
contribution in
[https://github.com/gomods/athens/pull/1874](https://github.com/gomods/athens/pull/1874)

**Full Changelog**:
gomods/athens@v0.13.2...v0.13.3

### [`v0.13.2`](https://github.com/gomods/athens/releases/tag/v0.13.2)

[Compare
Source](https://github.com/gomods/athens/compare/v0.13.1...v0.13.2)

#### What's Changed

- Send standard logger's output to logrus by
[@&#8203;mikesep](https://github.com/mikesep) in
[https://github.com/gomods/athens/pull/1912](https://github.com/gomods/athens/pull/1912)
- chore: fix broken links to 'absolutely everybody' blog post by
[@&#8203;darrylblake](https://github.com/darrylblake) in
[https://github.com/gomods/athens/pull/1914](https://github.com/gomods/athens/pull/1914)
- update-github-action(deps): bump golangci/golangci-lint-action from 3
to 4 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1915](https://github.com/gomods/athens/pull/1915)
- update-go-pkg(deps): bump github.com/gorilla/mux from 1.6.2 to 1.8.1
by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1917](https://github.com/gomods/athens/pull/1917)
- update-go-pkg(deps): bump github.com/stretchr/testify from 1.8.1 to
1.8.4 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1918](https://github.com/gomods/athens/pull/1918)
- update-go-pkg(deps): bump go.etcd.io/etcd/api/v3 from 3.5.9 to 3.5.12
by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1919](https://github.com/gomods/athens/pull/1919)
- Fix Markdown link in Storage docs by
[@&#8203;chriskuehl](https://github.com/chriskuehl) in
[https://github.com/gomods/athens/pull/1922](https://github.com/gomods/athens/pull/1922)
- Use quotes for args by
[@&#8203;matt0x6F](https://github.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1925](https://github.com/gomods/athens/pull/1925)
- Add log formatting settings by
[@&#8203;matt0x6F](https://github.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1926](https://github.com/gomods/athens/pull/1926)
- upgrade mongodb driver by
[@&#8203;xytan0056](https://github.com/xytan0056) in
[https://github.com/gomods/athens/pull/1928](https://github.com/gomods/athens/pull/1928)
- update-go-pkg(deps): bump github.com/lib/pq from 1.10.7 to 1.10.9 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gomods/athens/pull/1923](https://github.com/gomods/athens/pull/1923)
- Rework logging defaults by
[@&#8203;matt0x6F](https://github.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1927](https://github.com/gomods/athens/pull/1927)

#### New Contributors

- [@&#8203;darrylblake](https://github.com/darrylblake) made their
first contribution in
[https://github.com/gomods/athens/pull/1914](https://github.com/gomods/athens/pull/1914)
- [@&#8203;chriskuehl](https://github.com/chriskuehl) made their first
contribution in
[https://github.com/gomods/athens/pull/1922](https://github.com/gomods/athens/pull/1922)
- [@&#8203;matt0x6F](https://github.com/matt0x6F) made their first
contribution in
[https://github.com/gomods/athens/pull/1925](https://github.com/gomods/athens/pull/1925)

**Full Changelog**:
gomods/athens@v0.13.1...v0.13.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/gomods/athens-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants