Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The registry should check for Github repos and use the Github fetcher for it #223

Closed
arschles opened this issue Jul 8, 2018 · 5 comments

Comments

@arschles
Copy link
Member

arschles commented Jul 8, 2018

Other repositories can use the generic fetcher. This means the the registry should have a hard-coded check for github.com as the prefix for the package name

@michalpristas
Copy link
Member

i'm thikning whether we should not address #119 first

@arschles
Copy link
Member Author

arschles commented Jul 9, 2018

I feel like we can implement this now and figure out the tokens? What do you think @michalpristas

@michalpristas
Copy link
Member

yes, but tests might fail occasionally as limits are shared.
we can skip the test for github now and allow them later.
we will need access token and maybe some kind of special deal with github, that's what we were talking about with @bketelsen a while back if i remember correctly

@arschles
Copy link
Member Author

I am going to close this, since as part of #290 we are going to fill caches with only go get calls. That way, we don't have to write any logic to parse imports, etc...

@ghost
Copy link

ghost commented Jul 26, 2018

I figured you meant to hit close and comment so closing, reopen if you changed your mind @arschles 😁

@ghost ghost closed this as completed Jul 26, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants