Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for api.github.com limits #119

Closed
michalpristas opened this issue Apr 3, 2018 · 7 comments
Closed

Workaround for api.github.com limits #119

michalpristas opened this issue Apr 3, 2018 · 7 comments
Assignees
Labels
proxy Work to do on the module proxy question Further information is requested
Milestone

Comments

@michalpristas
Copy link
Member

Using vgo fetching we are hitting limits set by github.com for anonymous users.
We need to find a way how to authenticate to github from Olympus.
As we might event hit limits set for individual users some agreement with github would be nice.

If the agreement is out of option we need to find a workaround.

@arschles
Copy link
Member

arschles commented Apr 3, 2018

We need to find a way how to authenticate to github from Olympus

For now, let's put a token into our requests as the basic first step.

some agreement with github would be nice

👍

@michalpristas
Copy link
Member Author

do we need some shared account? what is the best practice here

@airylinus
Copy link

May be you can use Personal Access Code, find more on github.com here

@ghost
Copy link

ghost commented Jul 9, 2018

I wonder if we can get a token under the org. Like a personal one but for @gomods

@arschles
Copy link
Member

arschles commented Jul 9, 2018

Good question, I will look into this

@ghost ghost added question Further information is requested registry labels Jul 26, 2018
@arschles arschles added the proxy Work to do on the module proxy label Oct 11, 2018
@arschles arschles added this to the preview milestone Oct 11, 2018
@arschles
Copy link
Member

I've added a preview label to this because we should at least look into a GH token to handle high volumes of go gets for "misses"

@arschles arschles removed the registry label Oct 11, 2018
@arschles
Copy link
Member

arschles commented Dec 6, 2018

Currently if you set up a .netrc file on the machine that you run Athens from, the go mod download calls that Athens does on the backend will respect the token you set in the file.

Closing

@arschles arschles closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy Work to do on the module proxy question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants