Provider - fix debit notes property #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tworec
approved these changes
Mar 2, 2021
Comment on lines
146
to
151
| if let Ok(deadline_prop) = offer.pointer_mut(DEBIT_NOTE_ACCEPT_TIMEOUT_PROP) { | ||
| *deadline_prop = | ||
| serde_json::Value::Number(req_deadline.num_seconds().into()); | ||
| } else { | ||
| bail!("Unable to set property {}", DEBIT_NOTE_ACCEPT_TIMEOUT_PROP); | ||
| } |
There was a problem hiding this comment.
We know that this property exists, because we checked it above (our_deadline)
Comment on lines
13
to
21
| impl From<&Proposal> for ProposalView { | ||
| fn from(p: &Proposal) -> Self { | ||
| ProposalView { | ||
| json: expand(p.properties), | ||
| agreement_id: p.proposal_id, | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
It should be in AgreementUtils
There was a problem hiding this comment.
I wanted not to touch it this time
nieznanysprawiciel
force-pushed
the
provider/fix-debit-notes-property
branch
from
15cba08 to
4151ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1100
Property name in Agreement differs from property name in Offer since it must be prefixed with "/offer/properties".