Zero amount invoices & debit notes

[pnowosie]

PAY-182

I've modified invoice_flow example [LINK],
debit_note_flow modified accordingly.

Result of the db query

 sqlite3 payment.db
SQLite version 3.22.0 2018-01-22 18:45:57
Enter ".help" for usage hints.
sqlite> SELECT id, role, status FROM pay_invoice ;
579a9f81-5fe1-4e56-abb0-e6d2674bbad0|P|SETTLED
579a9f81-5fe1-4e56-abb0-e6d2674bbad0|R|SETTLED

sqlite> SELECT id, role, status, total_amount_due FROM pay_debit_note ;
860a887f-5b0c-4dfe-a4c8-c743cbddf87c|P|SETTLED|0
860a887f-5b0c-4dfe-a4c8-c743cbddf87c|R|SETTLED|0
(...)

sqlite> SELECT * FROM pay_debit_note_event ;
860a887f-5b0c-4dfe-a4c8-c743cbddf87c|0x77bcd35db905a9c52ab17fe43dc4d91a5bdccbe0|RECEIVED|2021-02-11 14:07:45.198|
860a887f-5b0c-4dfe-a4c8-c743cbddf87c|0xbc3424be7e8e5e7f1df62ce70984a54376889b6b|ACCEPTED|2021-02-11 14:07:46.181|
860a887f-5b0c-4dfe-a4c8-c743cbddf87c|0xbc3424be7e8e5e7f1df62ce70984a54376889b6b|SETTLED|2021-02-11 14:07:46.181|
(...)

[maaktweluit]

LGTM!

Tested all examples and they are working, except for debit_note_flow on dummy.
Guess that was already broken so we can fix that in a separate PR.

Your gist also has a small error now:

curl https://gist.githubusercontent.com/pnowosie/6553be29d2cfd58c2ef5947334d719d7/raw/1276966f6cb6d7efc34b6878207a3015d353e89d/invoice_flow_example.patch | git apply -v

[maaktweluit]

small nit: would not import this at the top of the file or only 1 use

Suggested change

	std::thread::sleep(Duration::from_millis(100));
	std::thread::sleep(actix::clock::Duration::from_millis(100));

Suggested change

	std::thread::sleep(Duration::from_millis(100));
	std::thread::sleep(Duration::from_millis(100));

[Wiezzel]

I suggest commenting the crucial lines in the code, otherwise alright.