-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prek/net cleanup #189
Merged
Merged
Prek/net cleanup #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Emit cmdline for each mount: * storage: vol-{k}={path}[,errors={errors}]:{device id} * ram: vol-{k}={path},size={size} * Minimal implementation of qcow2 to create files for storage. * Emit nvidia=true cmdline to signify that the last vdX is the nvidia drive.
* Assign serial numbers of the form vol-{k} to identify external storage. * Emit command line parameters vol-{k}-path=.. and vol-{k}-errors for each of the external drives. * Split tmpfs specification into vol-{k}-path=.. and vol-{k}-size. * Assign serial `vol-nvidia` to the nvidia files drive. * Don't emit command line nvidia=true
* self-test didn't remove its artifacts from /tmp, which wasn't harmful when those were only directories but with the introduction of qcow2 storage, the storage leak became considerable. Now each invocation of the self-test creates it's dedicated subdirectory within /tmp which is deleted after the test concludes. * lower storage sizes for self-test.
* Temporarily disable nvidia storage support
Extra: * hide mkfs.ext2 output * validate that the failure to open /sys/class/block/vdX/serial is reported as the absence of the file only when errno is ENOENT. Fail otherwise.
This reverts commit 0261241.
This reverts commit cc28e2e.
* Handle missing vol- envs properly * Fix memory leaks
83f73b5
to
596ee6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.