docs: updated web examples to show how to debug in browser #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgordel
reviewed
Feb 26, 2024
| @@ -115,7 +115,7 @@ jobs: | |||
| uses: ./.github/actions/prepare-tests | |||
|
|
|||
| - name: Run web server | |||
| run: docker exec -t -d docker-requestor-1 /bin/sh -c "cd /golem-js/examples/web && node app.mjs" | |||
| run: docker exec -t -d docker-requestor-1 /bin/sh -c "cd /golem-js/examples && npm run web" | |||
There was a problem hiding this comment.
using serve is ok, but we need to solve the problem with tests for cypress examples for docs, which were previously served by the old app.mjs ..
maybe for testing we will need to copy these examples from docs-example to web/dist.. or somehow configure serve to serve files from docs-example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.