Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JobStatus backward change from Interrupted to Finished #174

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Fix JobStatus backward change from Interrupted to Finished #174

merged 11 commits into from
Jul 16, 2024

Conversation

nieznanysprawiciel
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel commented Jul 12, 2024 •
edited
Loading

resolves: #164

@nieznanysprawiciel nieznanysprawiciel linked an issue Jul 12, 2024 that may be closed by this pull request
Race conditions between Interrupted job and Requestor attempting to terminate #164
Closed
Base automatically changed from reduce-amount-of-logs to master July 15, 2024 09:02
prawilny
prawilny approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@prawilny prawilny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only left some nitpicks.

Golem.Tests/JobStatusTests.cs Outdated Show resolved Hide resolved
Golem/Job.cs Show resolved Hide resolved
Golem.Tools/GolemRequestor.cs Outdated Show resolved Hide resolved
Golem.Tools/SampleApp.cs Outdated Show resolved Hide resolved
@prawilny prawilny self-requested a review July 16, 2024 13:56
@nieznanysprawiciel nieznanysprawiciel merged commit 7c4e7e4 into master Jul 16, 2024
2 checks passed
@nieznanysprawiciel nieznanysprawiciel deleted the handle-new-termination-reasons branch July 16, 2024 14:44
@nieznanysprawiciel nieznanysprawiciel mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prawilny prawilny prawilny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race conditions between Interrupted job and Requestor attempting to terminate
2 participants
@nieznanysprawiciel @prawilny