Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/Crocmagnon/fatcontext from 0.6.0 to 0.7.0 #5334

Closed
wants to merge 2 commits into from

Conversation

Crocmagnon
Copy link
Contributor

@Crocmagnon Crocmagnon commented Jan 16, 2025

@ldez ldez changed the title feat: fatcontext settings build(deps): bump github.com/Crocmagnon/fatcontext from 0.6.0 to 0.7.0 Jan 16, 2025
@ldez ldez self-requested a review January 16, 2025 23:13
@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Jan 16, 2025
@ldez ldez added this to the next milestone Jan 16, 2025
@ldez
Copy link
Member

ldez commented Jan 16, 2025

It is better to let the dependabot handle the update even if there are modifications to the implementation.
Because globally, it takes less time for me to implement than to review a PR.

@Crocmagnon
Copy link
Contributor Author

Oh sorry about that I didn't know. Thanks for the heads up! Feel free to close this PR if you prefer implementing it yourself instead, I won't be offended :)

@ldez
Copy link
Member

ldez commented Jan 16, 2025

the update created a regression with cgo, I will check that.

runtime error: invalid memory address or nil pointer dereference: goroutine 323 [running]:
runtime/debug.Stack()
	/usr/lib/go/src/runtime/debug/stack.go:26 +0x5e
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe.func1()
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_action.go:50 +0x277
panic({0x19a4240?, 0x2802480?})
	/usr/lib/go/src/runtime/panic.go:785 +0x132
github.com/Crocmagnon/fatcontext/pkg/analyzer.(*runner).run.func1({0x1e47978, 0xc001019e60})
	/home/ldez/sources/go/pkg/mod/github.com/!crocmagnon/[email protected]/pkg/analyzer/analyzer.go:65 +0xf9
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder(0xc0009582d0, {0xc002a83ab8?, 0x28325c0?, 0xffffffffffffffff?}, 0xc0018b5af8)
	/home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ast/inspector/inspector.go:96 +0x8f
github.com/Crocmagnon/fatcontext/pkg/analyzer.(*runner).run(0xc00110ade2, 0xc0027862a0)
	/home/ldez/sources/go/pkg/mod/github.com/!crocmagnon/[email protected]/pkg/analyzer/analyzer.go:59 +0xea
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyze.func3(0xc0011c2280, 0xc0027862a0)
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_checker.go:182 +0xeb
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyze(0xc0011c2280)
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_checker.go:208 +0xa9c
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc001ac42d0, {0x1b6de9f, 0xa}, 0xc001ad1748)
	/home/ldez/sources/golangci/golangci-lint/pkg/timeutils/stopwatch.go:111 +0x44
github.com/golangci/golangci-lint/pkg/goanalysis.(*action).analyzeSafe(0xc00258b380?)
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_action.go:54 +0x71
github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze.func2(0xc0011c2280)
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_loadingpackage.go:83 +0xa5
created by github.com/golangci/golangci-lint/pkg/goanalysis.(*loadingPackage).analyze in goroutine 162
	/home/ldez/sources/golangci/golangci-lint/pkg/goanalysis/runner_loadingpackage.go:78 +0x1e9

@Crocmagnon
Copy link
Contributor Author

Let me know if I need to fix something in fatcontext, or even send a PR and I'll gladly merge it 👍🏻

@ldez
Copy link
Member

ldez commented Jan 16, 2025

I found the problem and the fix, I'm adding some tests, and I will open a PR on fatcontext

@ldez
Copy link
Member

ldez commented Jan 16, 2025

Crocmagnon/fatcontext#38

I close this PR because you will need to create a new release.

@ldez ldez closed this Jan 16, 2025
@ldez ldez added the declined label Jan 16, 2025
@ldez ldez removed this from the next milestone Jan 16, 2025
@Crocmagnon
Copy link
Contributor Author

Done: Crocmagnon/fatcontext@v0.6.0...v0.7.1
Do you want to handle the patch for the settings yourself?

@ldez
Copy link
Member

ldez commented Jan 17, 2025

#5335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants