Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint tests by default #36

Closed
cloudlena opened this issue May 29, 2018 · 2 comments
Closed

Lint tests by default #36

cloudlena opened this issue May 29, 2018 · 2 comments
Labels
enhancement New feature or improvement

Comments

@cloudlena
Copy link

cloudlena commented May 29, 2018 •
edited
Loading

I think we shouldn't treat testing code as a second class citizen. In my opinion this sends a wrong message that somehow its not as important for test code to be clean as for non-test code. I think we should set --tests to true by default.
@cloudlena cloudlena changed the title Enable tests by default Lint tests by default May 29, 2018
@golangci golangci added the enhancement New feature or improvement label May 29, 2018
golangci pushed a commit that referenced this issue Jun 2, 2018
@jirfag
#52: #36: lint test files by default
8a09f69
golangci pushed a commit that referenced this issue Jun 2, 2018
@jirfag
#52: #36: lint test files by default
defc4a9
golangci pushed a commit that referenced this issue Jun 2, 2018
@jirfag
#52: #36: lint test files by default: set --tests=false to disable it
e5efb1c
@jirfag
Copy link
Contributor

jirfag commented Jun 2, 2018

Hello, thank you for the issue! I've enabled tests linting by default in #59

golangci pushed a commit that referenced this issue Jun 2, 2018
@jirfag
#52: #36: lint test files by default: set --tests=false to disable it
b082671
jirfag added a commit that referenced this issue Jun 2, 2018
@jirfag
Merge pull request #59 from golangci/feature/enabled-tests-linting-by…
68e1295 
…-default

#52: #36: lint test files by default
@jirfag jirfag closed this as completed Jun 2, 2018
@cloudlena
Copy link
Author

Nice. Thanks, @jirfag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jirfag @cloudlena