This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
golangci: support running errcheck with all its options #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow golangci/golangci-lint#223, I've added the option to run the errcheck linter with all its options. Also, kept backwards compatibility in order to do the transition in the golangci-lint package gradually.
a8m
added a commit
to a8m/golangci-lint
that referenced
this pull request
Sep 12, 2018
Add support for the exclude and ignore flags of errcheck. Note that, this commit depends on golangci/errcheck#1. We need to merge it first, update vendors and only then merge this one.
jirfag
approved these changes
Oct 3, 2018
jirfag
pushed a commit
to golangci/golangci-lint
that referenced
this pull request
Oct 10, 2018
Add support for the exclude and ignore flags of errcheck. Note that, this commit depends on golangci/errcheck#1. We need to merge it first, update vendors and only then merge this one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow golangci/golangci-lint#223, I've added the option to run the errcheck linter with all its options. Also, kept backward compatibility in order to do the transition in the golangci-lint package gradually.
/cc @jirfag