-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-go: add convenience function for getting ServiceDescriptorProtos #579
Conversation
Sorry for the noise. I think I see what's happening now. Because this is a dev branch of protobuf, |
The last error seems to be a context problem. I'll have to look, but it looks like the grpc plugin on dev is (and was before this PR) importing "context" instead of "x/net/context". This would be a problem, if true. |
I've become increasingly convinced that support for accessing |
Given that #364 (comment) has a more comprehensive plan for adding this functionality, what would you like to salvage from this current PR to add today? The tests you have seem to depend on the functionality that I prefer not adding at the present moment. |
@dsnet, a simple "nop" test that imports a |
Done. Are you okay with closing this PR as stale? |
SGTM, thanks. |
Like #516, but in the main go code generator instead of the grpc plugin.