Skip to content

idna: do not check ace prefix slashes in case of acePrefix not present #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

moredure
Copy link

@moredure moredure commented Jan 24, 2022

if this rule is not deleted valid domains failed to make ascii for example http://0-------------------------------------------------------------5.com

@gopherbot
Copy link
Contributor

This PR (HEAD: a3aec84) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/380514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 6631f2f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/380514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@moredure moredure changed the title Removed the rule since checked by acePrefix Do not check ace prefix slashes in case of acePrefix not present Jan 24, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: 51dc05a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/380514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@moredure moredure changed the title Do not check ace prefix slashes in case of acePrefix not present bugfix: do not check ace prefix slashes in case of acePrefix not present Jan 31, 2022
@moredure moredure changed the title bugfix: do not check ace prefix slashes in case of acePrefix not present idna: do not check ace prefix slashes in case of acePrefix not present Jan 31, 2022
@moredure
Copy link
Author

moredure commented Feb 1, 2022

whatwg/url#53 (comment)

@moredure moredure closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants