Use standard library's context.Context #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby DeSimone <[email protected]>
desimone
force-pushed
the
bdd/use-context-package
branch
from
268d385 to
485035c
Compare
bradfitz
approved these changes
Dec 27, 2019
|
Thanks for the quick review and merge @bradfitz 🎄 🎅 |
3 tasks
5 tasks
scbizu
added a commit
to ezbuy/groupcache
that referenced
this pull request
Sep 11, 2020
This reverts commit 215e871.
dmitshur
pushed a commit
that referenced
this pull request
Mar 31, 2021
Pull request #131 deleted the Context declaration, which broke most usages of this package since users needed to implement the interfaces mentioned in this package by referencing the groupcache.Context type. However, that type was removed from peers.go in the mentioned pull request. Technically, #131 is a breaking change since groupcache.Context was an interface{}, and the PR switched it to be context.Context. Fortunately, it seems that all users are passing a context.Context anyways so that the type safety just checks out. However, most users are still referencing groupcache.Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes replace the ad-hoc implementation of context with the standard library's version of context which has been available since Go 1.7. This was previously discussed in #68 .