-
Notifications
You must be signed in to change notification settings - Fork 18k
encoding/xml: add indent to xml.Comment #65737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1bc30fd
to
1aed0b2
Compare
This PR (HEAD: 1aed0b2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564575. Important tips:
|
This PR (HEAD: 39b323f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564575. Important tips:
|
This change adds xml.Comment's with indent but you are still able to add xml.Comment's in the same line as the xml.EndElement like before. You have to set indent to empty string: encoder.Indent("", "")
encoder.EncodeToken(xml.Comment("Comment text"))
encoder.Indent("", " ") |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564575. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/564575. |
Message from Dante TIEHRHAW: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564575. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564575. |
Add indent before and after xml.Comment
With this change the comment is added with indent at the start, like StartElement and indent at the end, like EndElement.
Fixes #56340