cmd/compile/internal/test: prevent failures in go tool dist test -msan #64573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mauri870 wants to merge 1 commit into golang:master from mauri870:hotfix/64256-compile-internal-test

+1 −1

Member

mauri870 commented Dec 6, 2023

This test is already marked with !race, but when running the tests with
-msan it allocates memory which throws off the test assertions. Marking
it !msan as well.


          cmd/compile/internal/test: prevent test failures in go tool dist test…

d725cc9

… -msan

This test is already marked with !race, but when running the tests with
-msan it allocates memory which throws off the test assertions. Marking
it !msan as well.

For golang#64256

mauri870 changed the title ~~cmd/compile/internal/test: prevent test failures in go tool dist test…~~ cmd/compile/internal/test: prevent failures in go tool dist test -msan

Contributor

gopherbot commented Dec 6, 2023

This PR (HEAD: d725cc9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/547758.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Mar 16, 2024

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 1, 2024

Message from Mauri de Souza Meneguzzo:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 1, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 1, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 1, 2024

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 2, 2024

Message from Mauri de Souza Meneguzzo:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547758.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet