runtime: fix tests when running with -msan #64572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mauri870 wants to merge 1 commit into golang:master from mauri870:hotfix/64256-msan-vet-errors

Member

mauri870 commented Dec 6, 2023 •

edited

Loading

Currently go test -msan runtime always fails on loong64, arm64
and amd64. Changed the variable name to sz to match the
function prototypes.


          runtime: fix vet errors for unknown variable name in msan routines

0ee1e3b

This CL fixes some warnings when running go tool dist test -msan about
an unknown variable "size". Update he variable name to sz to match the
function prototypes.

For golang#64256

Contributor

gopherbot commented Dec 6, 2023

This PR (HEAD: 0ee1e3b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/547696.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

mauri870 changed the title ~~runtime: fix vet errors for unknown variable name in msan routines~~ runtime: fix tests when running with -msan

Contributor

gopherbot commented Jan 9, 2024

Message from Keith Randall:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 9, 2024

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-09T00:52:50Z","revision":"4cf6e089808de2ea3b5090e543ffc5e9e4fec4cd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 9, 2024

Message from Keith Randall:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 9, 2024

Message from Keith Randall:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 9, 2024

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 9, 2024

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/547696.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          runtime: fix tests when running with -msan

b7c630d

Currently go test -msan runtime always fails on loong64, arm64
and amd64. Changed the variable name to sz to match the
function prototypes.

For #64256

Change-Id: Ida71197307016520deb39293927850d47845140a
GitHub-Last-Rev: 0ee1e3b
GitHub-Pull-Request: #64572
Reviewed-on: https://go-review.googlesource.com/c/go/+/547696
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Keith Randall <[email protected]>

Contributor

gopherbot commented Jan 9, 2024

This PR is being closed because golang.org/cl/547696 has been merged.

gopherbot closed this

ezz-no pushed a commit to ezz-no/go-ezzno that referenced this pull request


          runtime: fix tests when running with -msan

f97cacb

Currently go test -msan runtime always fails on loong64, arm64
and amd64. Changed the variable name to sz to match the
function prototypes.

For golang#64256

Change-Id: Ida71197307016520deb39293927850d47845140a
GitHub-Last-Rev: 0ee1e3b
GitHub-Pull-Request: golang#64572
Reviewed-on: https://go-review.googlesource.com/c/go/+/547696
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Keith Randall <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet