Skip to content

syscall: Use the service account to get user information #61972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s3cst4rs
Copy link

When calling user.Current() to get Username normally, everything is fine, but if the caller is a service user, err will be returned and Username cannot be obtained

After checking the code, I found an error when calling GetUserProfileDirectory() in current() to obtain information. The service account does not have a profile directory, so there will be an error of The system cannot find the file specified., but it does not affect others The acquisition of information should not directly return err to cause all information to be invalid

If you'd like to reproduce what I said, please run user.Current() in is

func main() {
username, err := user.Current()
if err != nil {
fmt.Println(err.Error())
} else {
fmt.Println(username.Username)
}
}

go build -o current.exe

Correct
C:>current.exe
TEST\Administrator

Incorrect
C:/inetpub/wwwroot/test/ >C:\current.exe
The system cannot find the file specified.

But in fact, we have already obtained other information at this time, such as the username

func lookupUsernameAndDomain(usid *syscall.SID) (username, domain string, e error) {
username, domain, t, e := usid.LookupAccount("")
if e != nil {
return "", "", e
}
if t != syscall.SidTypeUser {
return "", "", fmt.Errorf("user: should be user account type, not %d", t)
}
return username, domain, nil
}
func main() {
t, e := syscall.OpenCurrentProcessToken()
if e != nil {
return
}
defer t.Close()
u, e := t.GetTokenUser()
if e != nil {
return
}

username, domain, e := lookupUsernameAndDomain(u.User.Sid)
fmt.Println(domain + `\` + username)

}

go build -o current.exe

C:>current.exe
TEST\Administrator

C:/inetpub/wwwroot/test/ >C:\current.exe
IIS APPPOOL\test

@gopherbot
Copy link
Contributor

This PR (HEAD: 12cafc0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/518960.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants