net/http: pool transport gzip readers #61390

AlexanderYastrebov · 2023-07-17T01:03:04Z

goos: linux
goarch: amd64
pkg: net/http
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ClientGzip-8 621.0µ ± 2% 616.3µ ± 10% ~ (p=0.971 n=10)

         │    HEAD~1     │                 HEAD                 │
         │     B/op      │     B/op      vs base                │

ClientGzip-8 49.765Ki ± 0% 9.514Ki ± 2% -80.88% (p=0.000 n=10)

         │   HEAD~1   │               HEAD                │
         │ allocs/op  │ allocs/op   vs base               │

ClientGzip-8 57.00 ± 0% 52.00 ± 0% -8.77% (p=0.000 n=10)

Allocation saving comes from absent compress/flate.(*dictDecoder).init

Updates #61353

gopherbot · 2023-07-17T01:06:45Z

This PR (HEAD: cf5ad00) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-17T01:12:55Z

This PR (HEAD: 041cc00) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-17T01:18:47Z

Message from [email protected]:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-17T01:24:38Z

Message from [email protected]:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T17:00:10Z

Message from Bryan Mills:

Patch Set 2: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T18:12:33Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T18:46:05Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T19:46:48Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T22:13:04Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-19T16:58:28Z

This PR (HEAD: 8349b7d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-19T17:04:49Z

Message from Alexander Yastrebov:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-19T17:04:50Z

Message from [email protected]:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T16:55:39Z

Message from Damien Neil:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:24:46Z

This PR (HEAD: 607bd71) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-21T18:36:46Z

Message from [email protected]:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:42:46Z

Message from Alexander Yastrebov:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:42:55Z

This PR (HEAD: 94bcf3e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-21T18:55:16Z

Message from [email protected]:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-23T16:35:11Z

This PR (HEAD: b902028) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-23T16:49:43Z

Message from [email protected]:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-23T16:49:51Z

This PR (HEAD: 8854c57) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-23T16:57:02Z

Message from Alexander Yastrebov:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-23T17:04:23Z

Message from [email protected]:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T22:11:12Z

Message from Brad Fitzpatrick:

Patch Set 8:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T22:11:13Z

Message from Damien Neil:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T20:39:06Z

This PR (HEAD: 06cf2a9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-10T20:51:46Z

Message from [email protected]:

Patch Set 9:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T21:16:54Z

Message from Alexander Yastrebov:

Patch Set 9:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T22:18:13Z

Message from Damien Neil:

Patch Set 9: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T22:18:14Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-10T22:11:58Z","revision":"7da38e3a34211f43951b342da6da00468105debf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T22:36:23Z

Message from Damien Neil:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T22:36:24Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T22:36:25Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

For golang#61353

goos: linux goarch: amd64 pkg: net/http │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-8 621.0µ ± 2% 616.3µ ± 10% ~ (p=0.971 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-8 49.765Ki ± 0% 9.514Ki ± 2% -80.88% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-8 57.00 ± 0% 52.00 ± 0% -8.77% (p=0.000 n=10) Allocation saving comes from absent compress/flate.(*dictDecoder).init Updates golang#61353

gopherbot · 2025-04-17T11:16:10Z

Message from Sean Liao:

Patch Set 10: Auto-Submit+1 Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:10Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-04T12:28:33Z","revision":"14f462d105a977f97b2bdf2b559dea5992e0bc3e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:12Z

Message from Sean Liao:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:13Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:14Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:14Z

Message from Ian Lance Taylor:

Patch Set 10:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-17T11:16:25Z

This PR (HEAD: e26eb44) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-17T11:31:04Z

Message from Alexander Yastrebov:

Patch Set 10:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!

AlexanderYastrebov force-pushed the go61353-2 branch from cf5ad00 to 041cc00 Compare July 17, 2023 01:10

AlexanderYastrebov mentioned this pull request Jul 17, 2023

net/http: reuse gzip reader from pool for transport #61353

Open

AlexanderYastrebov force-pushed the go61353-2 branch from 041cc00 to 8349b7d Compare July 19, 2023 16:51

AlexanderYastrebov force-pushed the go61353-2 branch 2 times, most recently from a632c84 to 607bd71 Compare July 21, 2023 18:23

AlexanderYastrebov force-pushed the go61353-2 branch from 607bd71 to 94bcf3e Compare July 21, 2023 18:42

AlexanderYastrebov force-pushed the go61353-2 branch from 94bcf3e to b902028 Compare September 23, 2023 16:30

AlexanderYastrebov force-pushed the go61353-2 branch from b902028 to 8854c57 Compare September 23, 2023 16:43

AlexanderYastrebov force-pushed the go61353-2 branch from 8854c57 to 06cf2a9 Compare November 10, 2023 20:37

AlexanderYastrebov added 2 commits April 17, 2025 11:03

net/http: add client benchmark for gzip response

1baf68b

For golang#61353

AlexanderYastrebov force-pushed the go61353-2 branch from 06cf2a9 to e26eb44 Compare April 17, 2025 11:11

net/http: pool transport gzip readers #61390

Are you sure you want to change the base?

net/http: pool transport gzip readers #61390

Conversation

AlexanderYastrebov commented Jul 17, 2023 • edited Loading

gopherbot commented Jul 17, 2023

gopherbot commented Jul 17, 2023

gopherbot commented Jul 17, 2023

gopherbot commented Jul 17, 2023

gopherbot commented Jul 18, 2023

gopherbot commented Jul 18, 2023

gopherbot commented Jul 18, 2023

gopherbot commented Jul 18, 2023

gopherbot commented Jul 18, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Sep 23, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

gopherbot commented Apr 17, 2025

AlexanderYastrebov commented Jul 17, 2023 •

edited

Loading