Skip to content

os/exec: use pidfd for waiting and signaling of processes #60461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitar
Copy link
Contributor

@mitar mitar commented May 26, 2023

Using pidfd allows us to have a handle on the process and poll the handle to non-blocking wait for the process to exit.

Fixes #34396
Fixes #60321
Fixes #60320

@gopherbot
Copy link
Contributor

This PR (HEAD: 14ffe54) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/498615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 86ae506) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/498615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Using pidfd allows us to have a handle on the process and
poll the handle to non-blocking wait for the process to
exit.

Fixes golang#34396
Fixes golang#60321
Fixes golang#60320
@gopherbot
Copy link
Contributor

This PR (HEAD: 9459756) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/498615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Mitar:

Patch Set 2:

(14 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/498615.
After addressing review feedback, remember to publish your drafts!

@seankhliao
Copy link
Member

stale?

@seankhliao seankhliao closed this Apr 15, 2025
@mitar
Copy link
Contributor Author

mitar commented Apr 15, 2025

It is not stale, but no feedback was given on the CR. :-(

So I would be really sad if this is just closed. Please review the CR instead.

@seankhliao seankhliao reopened this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment