Skip to content

runtime/cgo: fix calls from C to go on linux/ppc64 #58976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

runtime/cgo: fix calls from C to go on linux/ppc64 #58976

wants to merge 2 commits into from
+3 −7

Conversation

zeldin
Copy link

@zeldin zeldin commented Mar 10, 2023

This fix makes cgo work correctly on linux/ppc64 (big endian). I tested it on Gentoo linux/ppc64 (ELF ABI v1)
with https://github.com/andreiavrammsd/cgo-examples.git and with Docker.

While I can't test if the removed code was somehow correct for the AIX case, I very much doubt that would be the case.

@gopherbot
Copy link
Contributor

This PR (HEAD: 7033ce0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/475495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

zeldin added 2 commits March 11, 2023 01:04
@zeldin
runtime/cgo: fix crosscall2 on linux/ppc64 (big endian)
d7bf8b0 
The "elf ABI v1" code in crosscall2 was incorrect because fn
is not a C function but a go function, and therefore does not
comply with the ELF ABI.
@zeldin
cmd/link: enable external linking on linux/ppc64
dcae630
@gopherbot
Copy link
Contributor

This PR (HEAD: dcae630) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/475495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Murphy:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marcus Comstedt:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Murphy:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marcus Comstedt:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marcus Comstedt:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Lynn Boger:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475495.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeldin @gopherbot