syscall/js: correct the wrong name in error for Value.Length method #58497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

xoba wants to merge 1 commit into golang:master from xoba:master

+1 −1

Contributor

xoba commented Feb 13, 2023 •

edited by seankhliao

Loading

when i call "Length" method on a js.Value object, and an error results, that error claims to originate from the "SetIndex" method, which is incorrect. instead, it actually originates from the "Length" method. thus, i changed the string from "Value.SetIndex" to "Value.Length". thanks for considering!


          syscall/js: corrected the wrong method name in error for Value.Length…

71147fd

… method

Contributor

gopherbot commented Feb 13, 2023

This PR (HEAD: 71147fd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/467656 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented May 22, 2023

Message from Jorropo:

Patch Set 1: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/467656.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467656.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467656.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467656.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 22, 2023

Message from Jorropo:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467656.
After addressing review feedback, remember to publish your drafts!

Contributor Author

xoba commented Jun 10, 2024

this bug still exists as of 2024-06-10, over one year later. can we get this fix merged? if so, how? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet