database/sql: wake cleaner if maxIdleTime set to less than maxLifetime #58490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

latentflip wants to merge 1 commit into golang:master from latentflip:fixes-45993

+2 −2

Contributor

latentflip commented Feb 13, 2023

The existing implementation wouldn't wake the connection cleaner if
maxIdleTime was set to a value less than maxLifetime while an existing
connection was open - resulting in idle connections not being discarded
until after the first maxLifetime had passed.

Fixes #45993

Contributor

gopherbot commented Feb 13, 2023

This PR (HEAD: dffce3b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/467655 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 13, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 14, 2023

Message from Daniel Theophanes:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 14, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 14, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 14, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 14, 2023

Message from Daniel Theophanes:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/467655.
After addressing review feedback, remember to publish your drafts!


          database/sql: wake cleaner when maxIdleTime less than maxLifetime

0d149d8

The existing implementation wouldn't wake the connection cleaner if
maxIdleTime was set to a value less than maxLifetime
resulting in idle connections being held
on to longer than expected.

Fixes golang#45993

latentflip force-pushed the fixes-45993 branch from dffce3b to 0d149d8 Compare

March 9, 2023 11:11

Contributor

gopherbot commented Mar 9, 2023

This PR (HEAD: 0d149d8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/467655 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request


          database/sql: wake cleaner if maxIdleTime set to less than maxLifetime

7b26389

The existing implementation wouldn't wake the connection cleaner if
maxIdleTime was set to a value less than maxLifetime while an existing
connection was open - resulting in idle connections not being discarded
until after the first maxLifetime had passed.

Fixes #45993

Change-Id: I074ed7ba9803354c8b3a41f2625ae0d8a7d5059b
GitHub-Last-Rev: 0d149d8
GitHub-Pull-Request: #58490
Reviewed-on: https://go-review.googlesource.com/c/go/+/467655
Auto-Submit: Sean Liao <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Sean Liao <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Daniel Theophanes <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet