runtime: fix misleading comments in amd64 assembly #54711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

samhocevar wants to merge 1 commit into golang:master from samhocevar-forks:patch/asm-comment

+2 −2

samhocevar commented Aug 27, 2022

The RBX register is actually callee-saved, as specified in the System V ABI used
by OpenBSD and Darwin. The comments are also now more consistent with the fact that
the code re-uses RBX after calling a function.


          runtime: fix misleading comments in amd64 assembly

d297e15

The RBX register is actually callee-saved, according to the System V ABI
used by OpenBSD and Darwin. The comments now make more sense in the context
of code that re-uses RBX after calling a function.

Contributor

gopherbot commented Aug 27, 2022

This PR (HEAD: d297e15) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/426214 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Aug 27, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 27, 2022

Message from Keith Randall:

Patch Set 1: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 27, 2022

Message from Keith Randall:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 23, 2023

Message from Keith Randall:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 23, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 23, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 23, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 23, 2023

Message from Keith Randall:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/426214.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet