-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: add missing //go:nosplit for efaceOf #49001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
a43383e
to
d5a47d5
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
d5a47d5
to
6bd54c2
Compare
This PR (HEAD: 6bd54c2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/356109 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/356109. |
Message from Michael Knyszek: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/356109. |
Message from Honsun Zhu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/356109. |
Message from Honsun Zhu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/356109. |
This PR (HEAD: 26ae367) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/356109 to see it. Tip: You can toggle comments from me using the |
This fix prevents additional stack checking code from being generated on func efaceOf to avoid unexpected growth of stack in child process. Fixes golang#48967
26ae367
to
238e9d4
Compare
This PR (HEAD: 238e9d4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/356109 to see it. Tip: You can toggle comments from me using the |
Message from Honsun Zhu: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/356109. |
This fix prevents additional stack checking code from being
generated on func efaceOf to avoid unexpected growth of stack
in child process.
Fixes #48967