encoding/xml: fix 'unsupported type' error on interface{} attributes #48625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given interface value that is actually a type implementing
encoding.TextMarshaler
orxml.MarshalerAttr
,marshalAttr
would return anunsupported type
error. The cause of this is that pointer and interface valuesare dereferences after checking if the supported interfaces are implemented.
Solve this by moving the dereference of the pointer and interface values to the
start of the function, and update the test cases to test for this situation.
Fixes #48624