-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/tls: replace tls Conn's rawInput with a small buffer when Read timeout #48229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I'll add more benchmark data later |
This PR (HEAD: c067980) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/347916 to see it. Tip: You can toggle comments from me using the |
code demos is in #43563 before optimization, 20k connections, 16k request size,500 qps:
cost totally 1g+ memory after optimization, 20k conns, 16k request size,500 qps:
about 700M memory Since I don't have a good enough server for more connections to test now.... I can't provide data for more than 20k connections currently |
This PR (HEAD: 9da3b34) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/347916 to see it. Tip: You can toggle comments from me using the |
This will reduce the rawInput buffer memory cost for large number of idle tls connections
This PR (HEAD: 51de0f8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/347916 to see it. Tip: You can toggle comments from me using the |
Message from ChunHui Cao: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347916. |
fixes #43563