-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/x509/pkix/pkix: add missing RFC 5280 RDN OIDs #44536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
RFC 5280 section 4.1.2.4 states that conforming implementations must/should expect a list of attribute types in Subject and Issuer names. Some of the required attributes were not supported by pkix.String(). This commit adds support for the missing RDN attributes.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 70abb7b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/295391 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/295391. |
This doesn't solve the issue. |
This PR modifies Go to comply to RFC 5280 with regard of human
readable representation of X.509 certificate distinguished names.
RFC 5280 section 4.1.2.4 states that conforming implementations
must/should expect a list of attribute types in Subject and
Issuer names. Some of the required attributes were not supported
by pkix.String(). This commit adds support for the missing RDN
attributes.
Updates #41750.