-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/quic: Signal unsupported
for key-update interop test
#67138
Comments
CC @neild |
|
OK, so as far as the interop runner is concerned, that is then lack of support for the test. I'd suggest you either do the key update earlier during the test, or mark it as unsupported? |
Change https://go.dev/cl/582855 mentions this issue: |
I believe this used to pass, but probably broke after https://go.dev/cl/564476, which reduces the total number of packets sent by the client in this test configuration under the 1000 packet threshold. It's a bit weird to set the key rotation policy specifically to make this test pass, but 1000 packets is a completely arbitrary number anyway, so just always rotating earlier might be simplest. |
Most other clients pass the test name in via a command line option, and then configure their default behavior as needed. Might want to do that too? (Or do a special client just for interop, but might be overkill.) |
We intentionally have few configuration parameters, and the interop client uses the public package API. So the question is how we'd configure this. Probably through a GODEBUG setting, but we don't have any GODEBUGs that adjust behavior at the moment so adding one would be a reasonably significant change. |
The QUIC interop runner "keyrotate" test requires that the client initiate a key rotation early in the connection. With our current ack frequency, it seems that we need to rotate within the first 300-400 packets for the test to pass. Reduce the initial key rotation from 1000 to 100 packets. Rotating earlier shouldn't have any real downsides (rotation is cheap and generally done once per connection, except for very long-lived connections), and this is simpler than providing a way to tune the rotation interval in one specific test. For golang/go#67138 Change-Id: I33d47ea35ed39f0a13c171adb2b0698f8c93050e Reviewed-on: https://go-review.googlesource.com/c/net/+/582855 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
Proposal Details
Based on https://interop.seemann.io/, go-x-net doesn't seem to support key updates. Please signal this to the runner by returning
unsupported
for this interop test case.The text was updated successfully, but these errors were encountered: