Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: rollback BoringCrypto fips-20220613 update [1.20 backport] #65322

Closed
gopherbot opened this issue Jan 26, 2024 · 7 comments
Closed

crypto: rollback BoringCrypto fips-20220613 update [1.20 backport] #65322

gopherbot opened this issue Jan 26, 2024 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.14

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #65321 to be considered for backport to the next 1.20 minor release.

@gopherbot please open backport issues for Go 1.20, Go 1.21, and Go 1.22 (if that works).

This is rolling back the #64717 cherry-picks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 26, 2024
@gopherbot gopherbot mentioned this issue Jan 26, 2024
Closed
@gopherbot gopherbot added this to the Go1.20.14 milestone Jan 26, 2024
@dagood dagood mentioned this issue Jan 30, 2024
Merged
@mknyszek
Copy link
Contributor

In the release meeting, we think should be very safe because this just returning to a previous tree state. Approved.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Jan 31, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 31, 2024
@mknyszek
Copy link
Contributor

@FiloSottile @rolandshoemaker Could you please create cherry-picks and/or reverts for the Go 1.20 release branch? The minor release is coming up very soon. Thanks.

@FiloSottile
Copy link
Contributor

@FiloSottile @rolandshoemaker Could you please create cherry-picks and/or reverts for the Go 1.20 release branch? The minor release is coming up very soon. Thanks.

Mailing the cherry-picks now!

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/560275 mentions this issue: [release-branch.go1.21] Revert "crypto/internal/boring: upgrade module to fips-20220613" +1

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/560276 mentions this issue: [release-branch.go1.20] Revert "crypto/internal/boring: upgrade module to fips-20220613" +1

@mknyszek
Copy link
Contributor

mknyszek commented Feb 1, 2024

Thank you!

gopherbot pushed a commit that referenced this issue Feb 1, 2024
@FiloSottile @mknyszek
[release-branch.go1.20] Revert "crypto/internal/boring: upgrade modul…
a2f4a5a 
…e to fips-20220613" +1

This reverts CL 553875 ("crypto/internal/boring: upgrade module to
fips-20220613") and CL 553876 ("crypto/tls: align FIPS-only mode with
BoringSSL policy").

Fixes #65322
Updates #65321
Updates #64717
Updates #62372

Change-Id: I0938b97e5b4904e6532448b8ae76e920d03d0508
Reviewed-on: https://go-review.googlesource.com/c/go/+/558796
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
Auto-Submit: Filippo Valsorda <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 09b5de4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560276
@gopherbot
Copy link
Contributor Author

Closed by merging a2f4a5a to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.14
Development

No branches or pull requests
3 participants
@FiloSottile @mknyszek @gopherbot