x/build/dashboard: add js-wasm-node18 builder with Node.js 18 LTS

[johanbrandhorst]

Our current wasm NodeJS support policy is to support the latest LTS only ¹². The latest long term support release of NodeJS is 18. The current js-wasm builders are using version 14. We should update our builders to use the latest LTS so that we can evolve our use of NodeJS primitives and ensure we support users using the latest version of NodeJS.

Footnotes

1. https://github.com/golang/go/issues/28360#issuecomment-474621552 ↩

2. https://github.com/golang/go/issues/56860#issuecomment-1321273696 ↩

[johanbrandhorst]

CC @neelance

[johanbrandhorst]

I started looking into this and ran into some issues doing a simple upgrade to 18. I'm documenting it here for myself and others attempting this upgrade. Doing a simple replace of setup_14.x with setup_18.x results in an error upgrading gnupg:

## Installing the NodeSource Node.js 18.x repo...


## Populating apt-get cache...

+ apt-get update
Get:1 http://deb.debian.org/debian sid InRelease [161 kB]
Get:2 http://deb.debian.org/debian sid/main amd64 Packages [9398 kB]
Fetched 9559 kB in 3s (3332 kB/s)   
Reading package lists... Done

## Installing packages required for setup: lsb-release gnupg...

+ apt-get install -y lsb-release gnupg
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libc6-dev : Breaks: libgcc-9-dev (< 9.3.0-5~) but 9.2.1-19 is to be installed
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.
Error executing command, exiting

It seems to have something to do with a debian upgrade, which leads me to believe that we may need to update the base image debian version, but this is all the debugging I've done so far.

[johanbrandhorst]

Changing from sid to bullseye fixes the error. I've submitted a CL with a fix for this: https://go-review.googlesource.com/c/build/+/455375.

[dmitshur]

I ended up not seeing this issue and mailed https://go.dev/cl/460036 while I was picking up some builder maintenance work this week (CC @golang/release). That CL takes a more gradual approach to upgrade the version by adding a new builder (with a different name), get it working, then drop the old one, instead of attempting to do an in-place upgrade. I think that should work better.

@johanbrandhorst I ran into the problem you described in #57017 (comment) too. I think we can keep sid, the problem is just that the "latest" tag is 3 years old because our newer Cloud Build configuration targets the "cloudbuild" tag instead. In CL 460036 I switched to using the "cloudbuild", though I see now we should likely update "latest" instead.

[gopherbot]

Change https://go.dev/cl/460036 mentions this issue: dashboard, env: add js-wasm-node18 builder

[dmitshur]

The builder seems to be working okay, but we can't switch fully to it yet.

Filed an umbrella tracking issue for updating js/wasm to support Node.js 18,
and will close this issue since the builder part of this is done.

[gopherbot]

Change https://go.dev/cl/460575 mentions this issue: dashboard: update js-wasm-node18 known issue and limit it to Go 1.21+