Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releasebot: provide binary release for darwin/arm64 for 1.16 #42756

Closed
dmitshur opened this issue Nov 21, 2020 · 6 comments
Closed

x/build/cmd/releasebot: provide binary release for darwin/arm64 for 1.16 #42756

dmitshur opened this issue Nov 21, 2020 · 6 comments
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Milestone
Go1.16

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 21, 2020 •
edited
Loading

Based on discussion in a release meeting, I understand our current plan is to aim to provide binaries (and installer) for darwin/arm64 in time for the Go 1.16 release.

I'm making this as the tracking issue which reflects the current state: there are release-blocker, NeedsInvestigation, okay-after-beta1 labels applied, and the Go1.16 milestone set. Perhaps this will need to change as time passes.

Ideally, this will be implemented by using a darwin/arm64 builder (issue #39782) if that builder becomes available soon. If that builder cannot be added in time, we may need to implement this via a temporary workaround.

CC @golang/release, @cherrymui, @aclements, @FiloSottile, @rsc.
@dmitshur dmitshur added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker arch-arm64 okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Nov 21, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Nov 21, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 21, 2020
@sod sod mentioned this issue Nov 26, 2020
Merged
@dmitshur dmitshur mentioned this issue Dec 4, 2020
Closed
@ameukam ameukam mentioned this issue Dec 9, 2020
Closed
@dmitshur
Copy link
Contributor Author

Our recently-updated plan here is to try to get this in before beta 1 this week. Removing okay-after-beta1 to reflect that status.

@dmitshur dmitshur removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/278435 mentions this issue: cmd/release: set macOS deployment target for darwin/arm64 too

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/278436 mentions this issue: cmd/release: add darwin-arm64 target

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/278772 mentions this issue: dashboard: remove known issue for darwin arm builder

gopherbot pushed a commit to golang/build that referenced this issue Dec 16, 2020
@dmitshur
cmd/releasebot, cmd/release: add darwin-arm64 target for Go 1.16
4682f4a 
For golang/go#42756.

Change-Id: Ia28fb6878617715fb674ccfad0c5801c8925270b
Reviewed-on: https://go-review.googlesource.com/c/build/+/278436
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Dec 17, 2020
@toothrot
dashboard: remove known issue for darwin arm builder
911ac7d 
The builder successfully passes all.bash and produces binary releases.

Updates golang/go#42756
Fixes golang/go#39782

Change-Id: I554a1e3541d185958103e11dcc4b2514445d8275
Reviewed-on: https://go-review.googlesource.com/c/build/+/278772
Trust: Alexander Rakoczy <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@dmitshur
Copy link
Contributor Author

With issue #39782 being resolved now, CL 278436, and additional internal release workflow changes to codesign and notarize macOS binaries, and testing, the work needed be able to provide a binary release for the new darwin/arm64 port has been done.

The upcoming Go 1.16 Beta 1 release and further Go 1.16 releases will have go*.darwin-arm64.pkg installer and go*.darwin-arm64.tar.gz archive files provided at https://golang.org/dl/. Closing.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/278787 mentions this issue: internal/dl: categorize new darwin/arm64 binaries better

gopherbot pushed a commit to golang/website that referenced this issue Dec 17, 2020
@dmitshur
internal/dl: categorize new darwin/arm64 binaries better
8d60aee 
We want the new darwin/arm64 installer and archive to be placed next
to the original darwin/amd64 files, not under "Other Ports". Also
highlight (make bold) the darwin/arm64 installer (but not archive).

The "pretty" version of the architecture will be displayed as "ARMv8",
and maybe should be made more macOS-specific in the future.

Updates golang/go#42756.

Change-Id: I5e95a3b93d30253d8fa291d153b3f96f49f9ab5d
Reviewed-on: https://go-review.googlesource.com/c/website/+/278787
Trust: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@dmitshur dmitshur mentioned this issue Jan 21, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot