x/tools/gopls: reduce memory usage #30309

mattn · 2019-02-19T09:59:35Z

What version of Go are you using (`go version`)?

$ go version
go version devel +a10b4cff91 Sun Feb 17 04:46:20 2019 +0000 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\mattn\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\mattn\go
set GOPROXY=
set GORACE=
set GOROOT=C:\go
set GOTMPDIR=
set GOTOOLDIR=C:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\mattn\AppData\Local\Temp\go-build232338458=/tmp/go-build -gno-record-gcc-switches

What did you do?

Install gopls from latest x/tools/cmd/gopls, open daemon.go with vim-lsp.

And send textDocument/completion request from vim-lsp.

What did you expect to see?

In my personal experience, I thought gopls take about 500-800MB memory usage.

What did you see instead?

gopls take 3.5 GB memory usage.

The text was updated successfully, but these errors were encountered:

pwaller · 2019-02-19T11:48:49Z

I second this.

Whilst using gopls, I notice a steady increase of memory until it OOMs my system (which has 30GiB spare). I've been using gopls on the go compiler itself, and on the x/tools repository. I regularly have to kill gopls to prevent it from using too much RAM.

bcmills · 2019-02-28T15:07:52Z

CC @stamblerre @ianthehat

stamblerre · 2019-02-28T16:19:54Z

We are currently working on a number of improvements to gopls, particularly caching, which should solve a lot of these issues. As of right now, gopls calls go/packages.Load on every keystroke, which is likely why it requires so much memory. There should be updates on this soon.

gopherbot · 2019-03-03T05:58:39Z

Change https://golang.org/cl/164779 mentions this issue: internal/lsp: handle initializationOptions

gopherbot · 2019-03-06T18:58:39Z

Change https://golang.org/cl/165438 mentions this issue: internal/lsp: add cache for type information

This change adds an additional cache for type information, which here is just a *packages.Package for each package. The metadata cache maintains the import graph, which allows us to easily determine when a package X (and therefore any other package that imports X) should be invalidated. Additionally, rather than performing content changes as they happen, we queue up content changes and apply them the next time that any type information is requested. Updates golang/go#30309 Change-Id: Iaf569f641f84ce69b0c0d5bdabbaa85635eeb8bf Reviewed-on: https://go-review.googlesource.com/c/tools/+/165438 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>

mattn · 2019-03-11T01:27:41Z

I'm trying latest master branch with same file.

memory usage is improved considerably. And completion seems to be faster.

stamblerre · 2019-03-12T18:55:40Z

Closing for now, we can reopen as needed.

speedwheel · 2019-05-09T03:11:21Z

Is this normal? I get 7gb usage from gopls.exe

200sc · 2019-05-09T16:38:33Z

This also happened to me; wasn't actively using vscode at the time:

It kept using more memory until the machine was OOM.

Akumzy · 2019-05-10T16:21:20Z

Also in Ubuntu

stamblerre · 2019-05-10T22:07:04Z

What is the size of the projects that you were working on? gopls caches type information so the larger the project, the more memory it will use. It shouldn't keep using more memory or OOM, however, unless you are consistently adding new dependencies.

speedwheel · 2019-05-11T02:03:46Z

@stamblerre My go.mod has around 70 dependencies.

Akumzy · 2019-05-11T20:30:15Z

@stamblerre I have about 10 dependencies
I don't if the information below will be helpful
Screenshot from 2019-05-11 16-16-00

Screenshot from 2019-05-11 21-12-32

go.mod file


go 1.12

require ( github.com/Akumzy/ipc v0.0.0-20190428150754-76128748c1e5 github.com/asdine/storm v2.1.2+incompatible github.com/emersion/go-imap v1.0.0-beta.4 github.com/emersion/go-imap-idle v0.0.0-20180114101550-2af93776db6b github.com/emersion/go-message v0.9.2 github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197 github.com/stretchr/testify v1.3.0 // indirect go.etcd.io/bbolt v1.3.2 golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a )

go.som file


cloud.google.com/go v0.34.0 h1:eOI3/cP2VTU6uZLDYAoic+eyzzB9YyGmJ7eIjl8rOPg=
cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
github.com/Akumzy/ipc v0.0.0-20190428150754-76128748c1e5 h1:tiD/RAuIZlj2Dy8f5NUhNdBrH5M0F0xPPVVtU6Scug8=
github.com/Akumzy/ipc v0.0.0-20190428150754-76128748c1e5/go.mod h1:KtE0oJxRkmbN0MyDlw/wULkL0ey21TF2SpDOfJ+sJUk=
github.com/asdine/storm v2.1.2+incompatible h1:dczuIkyqwY2LrtXPz8ixMrU/OFgZp71kbKTHGrXYt/Q=
github.com/asdine/storm v2.1.2+incompatible/go.mod h1:RarYDc9hq1UPLImuiXK3BIWPJLdIygvV3PsInK0FbVQ=
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/emersion/go-imap v1.0.0-beta.4 h1:QglkDofK1RhU471SqcHxzRlSuPsCL6YpFc+NR5O6H6Q=
github.com/emersion/go-imap v1.0.0-beta.4/go.mod h1:mOPegfAgLVXbhRm1bh2JTX08z2Y3HYmKYpbrKDeAzsQ=
github.com/emersion/go-imap-idle v0.0.0-20180114101550-2af93776db6b h1:q4qkNe/W10qFGD3RWd4meQTkD0+Zrz0L4ekMvlptg60=
github.com/emersion/go-imap-idle v0.0.0-20180114101550-2af93776db6b/go.mod h1:o14zPKCmEH5WC1vU5SdPoZGgNvQx7zzKSnxPQlobo78=
github.com/emersion/go-message v0.9.1/go.mod h1:m3cK90skCWxm5sIMs1sXxly4Tn9Plvcf6eayHZJ1NzM=
github.com/emersion/go-message v0.9.2 h1:rJmtGZO1Z71PJDQXbC31EwzlJCsA/8kya6GnebSGp6I=
github.com/emersion/go-message v0.9.2/go.mod h1:m3cK90skCWxm5sIMs1sXxly4Tn9Plvcf6eayHZJ1NzM=
github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197 h1:rDJPbyliyym8ZL/Wt71kdolp6yaD4fLIQz638E6JEt0=
github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197/go.mod h1:G/dpzLu16WtQpBfQ/z3LYiYJn3ZhKSGWn83fyoyQe/k=
github.com/emersion/go-textwrapper v0.0.0-20160606182133-d0e65e56babe h1:40SWqY0zE3qCi6ZrtTf5OUdNm5lDnGnjRSq9GgmeTrg=
github.com/emersion/go-textwrapper v0.0.0-20160606182133-d0e65e56babe/go.mod h1:aqO8z8wPrjkscevZJFVE1wXJrLpC5LtJG7fqLOsPb2U=
github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
go.etcd.io/bbolt v1.3.2 h1:Z/90sZLPOeCy2PwprqkFa25PdkusRzaj9P8zm/KNyvk=
go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU=
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e h1:bRhVy7zSSasaqNksaRZiA5EEI+Ei4I1nO5Jh72wfHlg=
golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a h1:tImsplftrFpALCYumobsd0K86vlAs/eXGFms2txfJfA=
golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=

200sc · 2019-05-12T12:06:53Z

I had a few projects with modules open with ~70 dependencies between them.

WoLfulus · 2019-05-12T16:16:18Z

I have around 10 dependencies and memory goes up to 1GB right away

Dolmant · 2019-05-29T14:11:02Z

I have experienced similar issues for what it is worth, ubuntu works flawlessly running with <1gb ram but initially running in windows quickly ate all available ram rendering gopls inoperative. Recent updates have improved this significantly, now gopls will only use ~5gb with ~40 dependencies for a single project.

stamblerre · 2019-05-29T15:58:33Z

We have a few pending changes that will hopefully improve the memory consumption - I will update this issue once these changes are submitted.

gopherbot · 2019-06-01T02:12:09Z

Change https://golang.org/cl/178719 mentions this issue: internal/lsp: trim ASTs for which we do not require function bodies

This change trims the function bodies from the ASTs of files belonging to dependency packages. In these cases, we do not necessarily need full file ASTs, so it's not necessary to store the function bodies in memory. This change will reduce memory usage. However, it will also slow down the case of a user opening a file in a dependency package, as we will have to re-typecheck the file to get the full AST. Hopefully, this increase in latency will not be significant, as we will only need to re-typecheck a single package (all the dependencies should be cached). Updates golang/go#30309 Change-Id: I7871ae44499c851d1097087bd9d3567bb27db691 Reviewed-on: https://go-review.googlesource.com/c/tools/+/178719 Run-TryBot: Rebecca Stambler <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>

stamblerre · 2019-06-05T05:51:14Z

The change above was the first of these planned improvements. It would be really helpful to get feedback on it. Did memory consumption decrease for anyone on this thread?

Akumzy · 2019-06-05T15:24:07Z

I switch to Windows from Linux (Ubuntu) recently and I haven't notice any lag since then

jsravn · 2019-12-16T17:21:24Z

(setq lsp-gopls-server-args '("-rpc.trace" "--debug=localhost:6060")) should do the trick.

dwrz · 2019-12-16T17:29:03Z

Yep, that's what I have -- when I tried it last week it wasn't having any effect.

dwrz · 2019-12-16T18:43:59Z

Hopefully this is on the right track:

 Main Info Memory Metrics RPC Trace
GoPls memory usage
Stats
Allocated bytes	1,874,759,688
Total allocated bytes	27,826,168,120
System bytes	5,422,058,296
Heap system bytes	3,823,140,864
Malloc calls	328,987,833
Frees	309,344,009
Idle heap bytes	1,664,188,416
In use bytes	2,158,952,448
Released to system bytes	15,638,528
Heap object count	19,643,824
Stack in use bytes	1,344,241,664
Stack from system bytes	1,344,241,664
Bucket hash bytes	3,228,582
GC metadata bytes	190,748,672
Off heap bytes	9,416,594
By size
Size	Mallocs	Frees
0	0	0
8	5,937,615	5,463,178
16	62,172,147	59,529,419
32	105,959,191	99,970,666
48	32,586,016	29,370,218
64	23,455,382	22,104,325
80	11,692,136	10,895,865
96	4,782,414	3,965,587
112	1,251,115	1,175,280
128	3,514,623	3,382,241
144	14,696,691	13,772,588
160	9,697,051	9,606,337
176	8,473,294	7,405,670
192	4,022,748	3,916,726
208	6,710,206	6,634,774
224	4,886,396	4,113,227
240	512,857	388,860
256	611,621	509,291
288	941,235	763,448
320	530,070	430,645
352	342,435	260,203
384	765,073	284,602
416	182,057	160,201
448	76,485	68,972
480	58,594	56,157
512	101,509	98,480
576	37,235	35,434
640	30,912	30,313
704	22,933	22,523
768	6,832	6,670
896	28,810	28,071
1,024	66,962	65,195
1,152	9,491	9,118
1,280	8,060	7,920
1,408	5,744	5,616
1,536	10,193	10,054
1,792	69,264	68,793
2,048	36,226	35,270
2,304	11,438	11,228
2,688	5,422	5,235
3,072	4,625	4,476
3,200	1,478	1,446
3,456	4,391	4,309
4,096	50,499	49,535
4,864	5,826	5,614
5,376	3,458	3,330
6,144	4,673	4,502
6,528	1,686	1,640
6,784	1,007	981
6,912	746	723
8,192	70,139	69,641
9,472	4,297	4,131
9,728	341	325
10,240	4,214	4,130
10,880	959	928
12,288	3,282	3,230
13,568	3,809	3,742
14,336	2,882	2,741
16,384	5,253	5,111
18,432	2,991	2,949
19,072	1,126	1,098

I think this was related to goimports again -- changing the parameters of a function.

lsp-mode config:

(use-package lsp-mode
  :ensure t
  :hook (go-mode . lsp)
  :commands lsp
  :config
  (setq lsp-gopls-server-args '("-rpc.trace" "--debug=localhost:6060")))

go-mode config:

(use-package go-mode
  :ensure t
  :bind-keymap
  (("C-c t" . go-tag-add)
  ("C-c T" . go-tag-remove)
  ("C-c C-b" . pop-tag-mark))
  :config
  (add-hook 'before-save-hook #'gofmt-before-save)
  (add-hook 'go-mode-hook 'flycheck-mode)
  (add-hook 'go-mode-hook 'dumb-jump-mode)
  (if (executable-find "goimports")
      (setq gofmt-command "goimports"))
  (setq go-tag-args (list "-transform" "camelcase")))

I'm going to try setting go-mode to use gofmt instead of goimports and see if there's any improvement.

stamblerre · 2019-12-17T01:13:52Z

gopls should be able to perform import organization for you, so you should not need to run the goimports binary separately. https://github.com/golang/tools/blob/master/gopls/doc/emacs.md has the information on how to configure this. This doesn't explain the gopls memory usage, but it may help since it will de-duplicate some of the work your machine is doing.

dwrz · 2019-12-17T13:45:05Z

Thank you. I didn't notice any issues with memory usage after removing goimports from my go-mode config. I've just added the save-hooks specified in the docs and will see how things go.

dwrz · 2019-12-19T17:24:44Z

Unfortunately, it looks like I'm still running into memory usage issues. I think this was related to imports again -- a typo in accessing a struct field seemed to cause a spike in CPU and memory usage. I had to manually kill gopls to get control back.

Hope this is still helpful:

 Main Info Memory Metrics RPC Trace
GoPls memory usage
Stats
Allocated bytes	3,513,551,600
Total allocated bytes	23,534,938,824
System bytes	7,178,594,392
Heap system bytes	4,375,805,952
Malloc calls	248,781,847
Frees	209,081,325
Idle heap bytes	814,415,872
In use bytes	3,561,390,080
Released to system bytes	22,593,536
Heap object count	39,700,522
Stack in use bytes	2,468,151,296
Stack from system bytes	2,468,151,296
Bucket hash bytes	3,214,374
GC metadata bytes	251,400,192
Off heap bytes	12,192,818
By size
Size	Mallocs	Frees
0	0	0
8	5,084,837	4,311,387
16	48,989,694	41,724,412
32	71,900,063	61,706,671
48	26,418,769	20,442,178
64	19,835,705	17,607,378
80	10,926,038	9,475,692
96	5,458,456	3,835,888
112	928,812	798,434
128	2,195,352	1,903,198
144	11,638,153	8,902,226
160	6,965,488	5,972,364
176	7,282,924	5,039,367
192	3,011,182	2,487,809
208	4,960,396	4,364,049
224	2,188,038	1,503,377
240	418,976	192,544
256	678,848	474,599
288	1,350,681	983,676
320	547,058	340,549
352	411,855	239,361
384	961,807	253,902
416	218,154	165,008
448	64,591	43,486
480	172,986	162,323
512	106,509	100,322
576	50,746	46,541
640	38,054	36,929
704	15,882	15,444
768	7,102	6,838
896	49,097	48,353
1,024	59,821	58,282
1,152	18,140	17,791
1,280	5,736	5,646
1,408	13,189	13,047
1,536	5,326	5,216
1,792	84,438	83,832
2,048	31,352	30,071
2,304	12,648	12,396
2,688	9,108	8,895
3,072	3,511	3,432
3,200	2,577	2,530
3,456	2,503	2,430
4,096	45,466	44,136
4,864	10,538	10,354
5,376	3,718	3,629
6,144	5,584	5,509
6,528	1,669	1,633
6,784	751	734
6,912	1,739	1,718
8,192	67,701	67,056
9,472	6,654	6,510
9,728	338	320
10,240	3,435	3,383
10,880	699	677
12,288	4,225	4,179
13,568	2,446	2,370
14,336	7,685	7,570
16,384	5,643	5,509
18,432	1,928	1,887
19,072	1,774	1,744

(use-package go-mode
  :ensure t
  :bind
  (("C-c C-b" . pop-tag-mark)
   ("C-c t" . go-tag-add)
   ("C-c T" . go-tag-remove))
  :config
  (defun lsp-go-install-save-hooks ()
    (add-hook 'before-save-hook #'lsp-format-buffer t t)
    (add-hook 'before-save-hook #'lsp-organize-imports t t))
  (add-hook 'go-mode-hook 'dumb-jump-mode)
  (add-hook 'go-mode-hook 'flycheck-mode)
  (add-hook 'go-mode-hook #'lsp-go-install-save-hooks)
  (setq go-tag-args (list "-transform" "camelcase")))

(use-package lsp-mode
  :ensure t
  :hook (go-mode . lsp)
  :commands lsp
  :config
  (setq lsp-gopls-server-args '("-rpc.trace" "--debug=localhost:6060")))

stamblerre · 2019-12-19T17:59:48Z

Yes, those numbers do seem problematic. Are you working on a public project that I can try reproducing on or is this private code?

Also, do you experience the same issues at master? You can get master by running GO111MODULE=on go get golang.org/x/tools/gopls@master golang.org/x/tools@master.

dwrz · 2019-12-19T18:09:12Z

Unfortunately I'm working on private code. I'll try and see if I can get the behavior to trigger in a public codebase, though. I'll also set up master now -- thank you.

ajeecai · 2020-01-16T07:13:55Z

It also happens to me ... 10G +... It is easy to reproduce, git clone https://github.com/asticode/go-astilectron-demo, With vscode, remote SSH to open this folder, open message.go and main.go files and scroll to browse the code. In one minute the memory will increase to 10G (insider version), while with release version of vscode, the memory up to 7.6G.

stamblerre · 2020-01-16T17:16:26Z

@ajeecai: What version of gopls are you using (gopls version)? You report sounds like a memory leak that existed a few months ago. If you update to the latest version (GO111MODULE=on go get golang.org/x/tools/gopls), I don't think that you should see this behavior.

ajeecai · 2020-01-17T03:35:56Z

Hi @stamblerre Is this the latest version? I don't know how to update standalone gopls and what is its latest version.

stamblerre · 2020-01-17T17:56:01Z

@ajeecai: v0.2.2 is the latest released version, though we will be releasing an update sometime this month. If you'd like to try out the current master, you can run: GO111MODULE=on go get golang.org/x/tools/gopls@master golang.org/x/tools@master.

ajeecai · 2020-01-18T07:03:58Z

hi @stamblerre , with this command, the version of gopls looks downgrading

But as I edit the code in vscode, the memory usage looks extremely high, worse.

Do you have any change to try with the project I code mentioned, I think it is easy to reproduce.

stamblerre · 2020-01-21T17:47:05Z

@ajeecai: I am not able to reproduce with the example you've given, but it's possible there are other factors at play here. Can you share you enable debug logging and share your gopls logs here? See https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md#capturing-logs for more information. You can also enable the debug server, and we can try seeing what is using that much memory.

ajeecai · 2020-01-23T15:50:44Z

I have switched gopls back to 0.2.2, when the memory up to 9G, I have followed the instructions and captured the log information in attachments. Please take a look.
gopls_log.txt
gopls_6060.tar.gz

Thanks

stamblerre · 2020-01-24T21:42:57Z

Thank you for sharing this - something does appear to be going very wrong here, as the memory usage really is high, and you'll notice that there are many cancellation requests in the log, indicating that something is probably hanging. I'm afraid I won't be able to make much more progress in investigation without memory profiles, so if you'd be willing to collect some that would be very helpful. This can be done by running go tool pprof -web http://localhost:6060/debug/pprof/heap while gopls is running.

I would also highly recommend sticking with master (the v0.1.8 number was correct, sorry that it is misleading). A lot has changed since v0.2.2 came out, so I hope that might have some effect.

stamblerre · 2020-01-31T19:18:08Z

This issue is almost a year old, and a great deal has changed in gopls since that time. There are a lot of discussions here that are no longer relevant, so I am going to close this issue and use #36943 to track general memory improvements.

If you encounter a specific issue with your project, please open a new issue so that we can begin discussion separately.

@ajeecai: If you are able to produce profiles, please do create a new issue to share them, and we will continue investigating.

gopherbot added this to the Unreleased milestone Feb 19, 2019

bcmills added ToolSpeed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 28, 2019

pwaller mentioned this issue Mar 11, 2019

x/tools/cmd/gopls: data race on (*Server).client #30091

Closed

stamblerre closed this as completed Mar 12, 2019

stamblerre added the gopls Issues related to the Go language server, gopls. label Mar 12, 2019

stamblerre reopened this May 10, 2019

rvolosatovs mentioned this issue Jun 5, 2019

gotools: 2019-05-24 -> 2019-06-03 NixOS/nixpkgs#62725

Merged

10 tasks

stamblerre added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. ToolSpeed labels Jan 29, 2020

stamblerre modified the milestones: gopls unplanned, gopls/v1.0.0 Jan 29, 2020

stamblerre added Performance and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Jan 31, 2020

stamblerre closed this as completed Jan 31, 2020

ajeecai mentioned this issue Feb 14, 2020

x/tools/gopls: using a lot of memory #37223

Closed

stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020

golang locked and limited conversation to collaborators Jul 22, 2021

gopherbot added the FrozenDueToAge label Jul 22, 2021

x/tools/gopls: reduce memory usage #30309

x/tools/gopls: reduce memory usage #30309

Comments

mattn commented Feb 19, 2019 • edited Loading

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

pwaller commented Feb 19, 2019

bcmills commented Feb 28, 2019

stamblerre commented Feb 28, 2019

gopherbot commented Mar 3, 2019

gopherbot commented Mar 6, 2019

mattn commented Mar 11, 2019 • edited Loading

stamblerre commented Mar 12, 2019

speedwheel commented May 9, 2019

200sc commented May 9, 2019 • edited Loading

Akumzy commented May 10, 2019

stamblerre commented May 10, 2019

speedwheel commented May 11, 2019

Akumzy commented May 11, 2019

200sc commented May 12, 2019

WoLfulus commented May 12, 2019

Dolmant commented May 29, 2019

stamblerre commented May 29, 2019

gopherbot commented Jun 1, 2019

stamblerre commented Jun 5, 2019

Akumzy commented Jun 5, 2019

jsravn commented Dec 16, 2019

dwrz commented Dec 16, 2019

dwrz commented Dec 16, 2019 • edited Loading

stamblerre commented Dec 17, 2019

dwrz commented Dec 17, 2019

dwrz commented Dec 19, 2019 • edited Loading

stamblerre commented Dec 19, 2019

dwrz commented Dec 19, 2019

ajeecai commented Jan 16, 2020 • edited Loading

stamblerre commented Jan 16, 2020

ajeecai commented Jan 17, 2020

stamblerre commented Jan 17, 2020

ajeecai commented Jan 18, 2020

stamblerre commented Jan 21, 2020

ajeecai commented Jan 23, 2020

stamblerre commented Jan 24, 2020

stamblerre commented Jan 31, 2020

If you encounter a specific issue with your project, please open a new issue so that we can begin discussion separately.

mattn commented Feb 19, 2019 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mattn commented Mar 11, 2019 •

edited

Loading

200sc commented May 9, 2019 •

edited

Loading

dwrz commented Dec 16, 2019 •

edited

Loading

dwrz commented Dec 19, 2019 •

edited

Loading

ajeecai commented Jan 16, 2020 •

edited

Loading