net: missing interfaces on Windows #12301

AudriusButkevicius · 2015-08-24T20:48:03Z

package main

import(
    "fmt"
    "net"
)

func main(){
    ifs, err := net.Interfaces()
    if err != nil {
        fmt.Println(err)
    }
    for _, inf := range ifs {
        x, _ := inf.Addrs()
        fmt.Printf("%#v %s", inf, x)
    }
}

In 1.4.1 returns:

net.Interface{Index:5, MTU:1500, Name:"{E36EC396-D578-48C0-82D5-F55217877570}", HardwareAddr:net.HardwareAddr{0x94, 0xde, 0x80, 0xaf, 0x4b, 0x62}, Flags:0x0} [192.168.1.70]

In 1.5 returns:

net.Interface{Index:1, MTU:4294967295, Name:"Loopback Pseudo-Interface 1", HardwareAddr:net.HardwareAddr{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, Flags:0x15} [::1/28 127.0.0.1/16]

Any code relying on net.Interfaces() breaks (for example making multicasts to all interfaces, since Windows by default multicasts to some single interface)

What version of Go are you using (go version)?
go version go1.5 windows/amd64

What operating system and processor architecture are you using?
Windows 8.1 x64

What did you do?
Called net.Interfaces()

What did you expect to see?
My one external interface

What did you see instead?
My one loopback interface

ipconfig /all

c:\Go\src\net>ipconfig /all

Windows IP Configuration

   Host Name . . . . . . . . . . . . : Audrius
   Primary Dns Suffix  . . . . . . . :
   Node Type . . . . . . . . . . . . : Hybrid
   IP Routing Enabled. . . . . . . . : No
   WINS Proxy Enabled. . . . . . . . : No
   DNS Suffix Search List. . . . . . : lan

Ethernet adapter Ethernet 5:

   Connection-specific DNS Suffix  . : lan
   Description . . . . . . . . . . . : Hyper-V Virtual Ethernet Adapter #2
   Physical Address. . . . . . . . . : 94-DE-80-AF-4B-62
   DHCP Enabled. . . . . . . . . . . : Yes
   Autoconfiguration Enabled . . . . : Yes
   Link-local IPv6 Address . . . . . : fe80::58d9:707e:1173:32c%5(Preferred)
   IPv4 Address. . . . . . . . . . . : 192.168.1.70(Preferred)
   Subnet Mask . . . . . . . . . . . : 255.255.255.0
   Lease Obtained. . . . . . . . . . : 23 August 2015 13:46:11
   Lease Expires . . . . . . . . . . : 25 August 2015 13:46:22
   Default Gateway . . . . . . . . . : 192.168.1.254
   DHCP Server . . . . . . . . . . . : 192.168.1.254
   DHCPv6 IAID . . . . . . . . . . . : 1150606976
   DHCPv6 Client DUID. . . . . . . . : 00-01-00-01-1D-3C-8E-0C-94-DE-80-AF-4B-62
   DNS Servers . . . . . . . . . . . : fe80::9e97:26ff:fe78:cec2%5
                                       8.8.8.8
                                       4.4.8.8
   NetBIOS over Tcpip. . . . . . . . : Enabled

Tunnel adapter isatap.lan:

   Media State . . . . . . . . . . . : Media disconnected
   Connection-specific DNS Suffix  . : lan
   Description . . . . . . . . . . . : Microsoft ISATAP Adapter #4
   Physical Address. . . . . . . . . : 00-00-00-00-00-00-00-E0
   DHCP Enabled. . . . . . . . . . . : No
   Autoconfiguration Enabled . . . . : Yes

netsh interface show interface


Admin State    State          Type             Interface Name
-------------------------------------------------------------------------
Enabled        Connected      Dedicated        Ethernet 3
Enabled        Connected      Dedicated        Ethernet 5

Test output:

c:\Go\src\net>go test -v -run=Interface
=== RUN   TestInterfaces
--- PASS: TestInterfaces (0.00s)
        interface_test.go:79: "Loopback Pseudo-Interface 1": flags "up|loopback|multicast", ifindex 1, mtu 4294967295
        interface_test.go:80: hardware address "00:00:00:00:00:00:00:00"
        interface_test.go:202: interface address "::1/28"
        interface_test.go:202: interface address "127.0.0.1/16"
        interface_test.go:223: joined group address "ff02::c"
        interface_test.go:223: joined group address "239.255.255.250"
=== RUN   TestInterfaceAddrs
--- PASS: TestInterfaceAddrs (0.00s)
        interface_test.go:202: interface address "fe80::58d9:707e:1173:32c/28"
        interface_test.go:202: interface address "192.168.1.70/16"
        interface_test.go:202: interface address "::1/28"
        interface_test.go:202: interface address "127.0.0.1/16"
        interface_test.go:202: interface address "fe80::5efe:c0a8:146/28"
PASS
Socket statistical information:
(inet4, datagram, udp): opened=4, connected=0, listened=0, accepted=0, closed=4, openfailed=0, connectfailed=0, listenfailed=0, acceptfailed=0, closefailed=0

ok      net     0.124s

The text was updated successfully, but these errors were encountered:

AudriusButkevicius · 2015-08-24T20:54:58Z

Strangely, net.InterfaceAddrs() returns the correct addresses, though net.InterfaceByIndex() nor net.InterfaceByName() does not.

AudriusButkevicius · 2015-08-24T21:21:17Z

Seems that it has been broken by ea22a08 by @mattn.

The problem seems to lie in getInterfaceInfos() which only returns info for the loopback adapter.
Though it's not obvious to me why that happens.

mikioh · 2015-08-24T22:03:53Z

@AudriusButkevicius,

Please take a look at https://github.com/golang/go/blob/master/CONTRIBUTING.md and let us know your environment information. Also can you show us the output of "go test -v -run=Interface at $GOROOT/src/net" and "ipconfig? ifconfig? netsh interfaces show?" on the node? (Please anonymize IDs in the output if necessary)

AudriusButkevicius · 2015-08-24T23:10:59Z

I edited my original post.

mikioh · 2015-08-25T01:01:15Z

Thanks. Just skimmed interface_windows.go and looks like the code is broken. At least about the following:

It doesn't list up all equipped interfaces because of https://github.com/golang/go/blob/master/src/net/interface_windows.go#L110
It makes wrong address prefixes because of https://github.com/golang/go/blob/master/src/net/interface_windows.go#L167. It should take prefixes instead of addresses, prefix lengths instead of socket structure lengths

AudriusButkevicius · 2015-08-25T01:27:40Z

Re 1, it does, because of for ; paddr != nil; paddr = paddr.Next {

In my case:
https://github.com/golang/go/blob/master/src/net/interface_windows.go#L93
chain contains 3 interfaces, but https://github.com/golang/go/blob/master/src/net/interface_windows.go#L98 contains only one info, hence interfaces get skipped at
https://github.com/golang/go/blob/master/src/net/interface_windows.go#L112

alexbrainman · 2015-08-25T01:45:07Z

@mikioh feel free to change. I know nothing about these. Happy to test / review if you need my help.

Alex

mikioh · 2015-08-25T01:45:31Z

@AudriusButkevicius,

Feel free to send a fix if you have a spare time. Unfortunately I'm not a windows user, have no windows box.

mikioh · 2015-08-25T01:46:14Z

Ah... @AudriusButkevicius, after you.

AudriusButkevicius · 2015-08-25T02:16:38Z

Well the win32 api is not clear to me, why it would return only info for a single interface, hence I am not sure what the right answer here is, hence pinging @mattn in hopes for comments.

mattn · 2015-08-25T09:03:57Z

I can reproduce. I'll look into it in later. But I don't have the old environment windowns XP 32bit that I made the change.no longer. Currently, I'm on windows 64bit.

AudriusButkevicius · 2015-08-25T09:35:40Z

Well for me I can reproduce on win8.1 x64, so shouldn't be a problem.

mattn · 2015-08-25T17:12:44Z

Hmm, I'm trying this on another 64bit windows. But test are passed. I'm confusing.

rsc · 2015-08-25T17:54:02Z

Why did this change from 1.4?

AudriusButkevicius · 2015-08-25T22:02:47Z

So tests are passing on my machine too, but they are not testing against ipconfig for example. So the output the tests produce is just wrong. As you can see in my case it only returns loopback addresses, though I have an 192 ip address too.

alexbrainman · 2015-08-26T01:43:59Z

Why did this change from 1.4?

http://golang.org/cl/3024

I don't understand most details. We just tried to make tests pass.

Alex

mikioh · 2015-08-27T21:05:12Z

@mattn,

If you have no spare time for now, I'll take a look a bit this weekend.

Why did this change from 1.4?

Old windows APIs used in the previous versions don't support IPv6 entirely.

mattn · 2015-08-28T13:33:56Z

Old windows APIs used in the previous versions don't support IPv6 entirely.

Yes, And some APIs doesn't support wide character set.

If you have no spare time for now, I'll take a look a bit this weekend.

Do it please. But I'll look if it possible.

0086 · 2015-09-14T07:49:39Z

The function getInterfaceInfos() in "src/net/interface_windows.go" return a incorrect slice,

return iia[:iilen-1], nil

This line code should be

return iia[:iilen], nil

gopherbot · 2015-09-14T08:01:21Z

CL https://golang.org/cl/14574 mentions this issue.

AudriusButkevicius · 2015-09-14T09:18:27Z

I'll test this later tonight.

AudriusButkevicius · 2015-09-14T20:04:51Z

👍 this fixes it.
So sad that it has missed 1.5.1

calmh · 2015-09-14T20:35:57Z

❤️ Thank you.

mattn · 2015-09-14T23:56:05Z

@AudriusButkevicius sorry and sad :(

gopherbot · 2015-09-20T03:01:27Z

CL https://golang.org/cl/14747 mentions this issue.

AudriusButkevicius · 2015-10-01T08:21:58Z

I see this hasn't been closed yet, though the changeset looked complete. Any issues along the way?

I really hope this makes it for 1.5.2.

alexbrainman · 2015-10-02T19:53:28Z

see this hasn't been closed yet, though the changeset looked complete. Any issues along the way?

CL https://golang.org/cl/14747 needs a test that won't let us break that code again. Also @mikioh proposed an alternative solution https://go-review.googlesource.com/#/c/14747/

Alex

AudriusButkevicius · 2015-10-21T15:44:06Z

Any way I can help you guys (@mikioh, @mattn) to get this fixed? I don't want to miss the 1.5.2 train.

gopherbot · 2015-11-09T03:01:59Z

CL https://golang.org/cl/16751 mentions this issue.

rsc · 2015-11-13T19:31:08Z

OK for Go 1.5.2.

gopherbot · 2015-11-16T23:00:40Z

CL https://golang.org/cl/16984 mentions this issue.

…faces on windows Fixes #12301 Change-Id: I8d01ec9551c6cff7e6129e06a7deb36a3be9de41 Reviewed-on: https://go-review.googlesource.com/16751 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-on: https://go-review.googlesource.com/16984 Run-TryBot: Austin Clements <[email protected]> Reviewed-by: Alex Brainman <[email protected]> Reviewed-by: Russ Cox <[email protected]>

gopherbot · 2015-12-04T11:01:01Z

CL https://golang.org/cl/17412 mentions this issue.

…on on windows The current implementation including Go 1.5 through 1.5.2 misuses Windows API and mishandles the returned values from GetAdapterAddresses on Windows. This change fixes various issues related to network facility information by readjusting interface and interface address parsers. Updates #5395. Updates #10530. Updates #12301. Updates #12551. Updates #13542. Fixes #12691. Fixes #12811. Fixes #13476. Fixes #13544. Also fixes fragile screen scraping test cases in net_windows_test.go. Additional information for reviewers: It seems like almost all the issues above have the same root cause and it is misunderstanding of Windows API. If my interpretation of the information on MSDN is correctly, current implementation contains the following bugs: - SIO_GET_INTERFACE_LIST should not be used for IPv6. The behavior of SIO_GET_INTERFACE_LIST is different on kernels and probably it doesn't work correctly for IPv6 on old kernels such as Windows XP w/ SP2. Unfortunately MSDN doesn't describe the detail of SIO_GET_INTERFACE_LIST, but information on the net suggests so. - Fetching IP_ADAPTER_ADDRESSES structures with fixed size area may not work when using IPv6. IPv6 generates ton of interface addresses for various addressing scopes. We need to adjust the area appropriately. - PhysicalAddress field of IP_ADAPTER_ADDRESSES structure may have extra space. We cannot ignore PhysicalAddressLength field of IP_ADAPTER_ADDRESS structure. - Flags field of IP_ADAPTER_ADDRESSES structure doesn't represent any of administratively and operatinal statuses. It just represents settings for windows network adapter. - MTU field of IP_ADAPTER_ADDRESSES structure may have a uint32(-1) on 64-bit platform. We need to convert the value to interger appropriately. - IfType field of IP_ADAPTER_ADDRESSES structure is not a bit field. Bitwire operation for the field is completely wrong. - OperStatus field of IP_ADAPTER_ADDRESSES structure is not a bit field. Bitwire operation for the field is completely wrong. - IPv6IfIndex field of IP_ADAPTER_ADDRESSES structure is just a substitute for IfIndex field. We cannot prefer IPv6IfIndex to IfIndex. - Windows XP, 2003 server and below don't set OnLinkPrefixLength field of IP_ADAPTER_UNICAST_ADDRESS structure. We cannot rely on the field on old kernels. We can use FirstPrefix field of IP_ADAPTER_ADDRESSES structure and IP_ADAPTER_PREFIX structure instead. - Length field of IP_ADAPTER_{UNICAST,ANYCAST,MULTICAST}_ADDRESS sturecures doesn't represent an address prefix length. It just represents a socket address length. Change-Id: Icabdaf7bd1d41360a981d2dad0b830b02b584528 Reviewed-on: https://go-review.googlesource.com/17412 Reviewed-by: Alex Brainman <[email protected]>

AudriusButkevicius mentioned this issue Aug 24, 2015

Syncthing 0.11.21 No Sync with info: No UPNP device detected syncthing/syncthing#2191

Closed

mikioh added the OS-Windows label Aug 24, 2015

mikioh added this to the Go1.5.1 milestone Aug 24, 2015

mikioh changed the title ~~net: Interfaces() regression in 1.5~~ net: Interfaces, InterfaceByIndex, InterfaceByName regression in 1.5 on windows Aug 24, 2015

ianlancetaylor modified the milestones: Go1.5.2, Go1.5.1 Sep 8, 2015

cbednarski mentioned this issue Nov 4, 2015

Network interfaces are not detected on Windows hashicorp/nomad#382

Closed

4 tasks

alexbrainman closed this as completed in c776cb9 Nov 10, 2015

rsc changed the title ~~net: Interfaces, InterfaceByIndex, InterfaceByName regression in 1.5 on windows~~ net: missing interfaces on Windows Nov 13, 2015

mikioh mentioned this issue Dec 9, 2015

net: Interface API for Go 1.5 through Go 1.5.2 is broken on Windows #13544

Closed

mikioh modified the milestones: Go1.6, Go1.5.2 Feb 3, 2016

golang locked and limited conversation to collaborators Feb 3, 2017

gopherbot added the FrozenDueToAge label Feb 3, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: missing interfaces on Windows #12301

net: missing interfaces on Windows #12301

AudriusButkevicius commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

mikioh commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

mikioh commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

alexbrainman commented Aug 25, 2015

mikioh commented Aug 25, 2015

mikioh commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

mattn commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

mattn commented Aug 25, 2015

rsc commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

alexbrainman commented Aug 26, 2015

mikioh commented Aug 27, 2015

mattn commented Aug 28, 2015

0086 commented Sep 14, 2015

gopherbot commented Sep 14, 2015

AudriusButkevicius commented Sep 14, 2015

AudriusButkevicius commented Sep 14, 2015

calmh commented Sep 14, 2015

mattn commented Sep 14, 2015

gopherbot commented Sep 20, 2015

AudriusButkevicius commented Oct 1, 2015

alexbrainman commented Oct 2, 2015

AudriusButkevicius commented Oct 21, 2015

gopherbot commented Nov 9, 2015

rsc commented Nov 13, 2015

gopherbot commented Nov 16, 2015

gopherbot commented Dec 4, 2015

net: missing interfaces on Windows #12301

net: missing interfaces on Windows #12301

Comments

AudriusButkevicius commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

mikioh commented Aug 24, 2015

AudriusButkevicius commented Aug 24, 2015

mikioh commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

alexbrainman commented Aug 25, 2015

mikioh commented Aug 25, 2015

mikioh commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

mattn commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

mattn commented Aug 25, 2015

rsc commented Aug 25, 2015

AudriusButkevicius commented Aug 25, 2015

alexbrainman commented Aug 26, 2015

mikioh commented Aug 27, 2015

mattn commented Aug 28, 2015

0086 commented Sep 14, 2015

gopherbot commented Sep 14, 2015

AudriusButkevicius commented Sep 14, 2015

AudriusButkevicius commented Sep 14, 2015

calmh commented Sep 14, 2015

mattn commented Sep 14, 2015

gopherbot commented Sep 20, 2015

AudriusButkevicius commented Oct 1, 2015

alexbrainman commented Oct 2, 2015

AudriusButkevicius commented Oct 21, 2015

gopherbot commented Nov 9, 2015

rsc commented Nov 13, 2015

gopherbot commented Nov 16, 2015

gopherbot commented Dec 4, 2015