Skip to content

Commit

Permalink
runtime: skip TestSegv/SegvInCgo earlier on ios
Browse files Browse the repository at this point in the history
It appears to sometimes hang instead of crashing,
which can cause subsequent tests to time out.

For #59947.

Change-Id: Id4ac3c0cd5f7f345334d3e0ed3f48e40b9ff191c
Reviewed-on: https://go-review.googlesource.com/c/go/+/492075
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
  • Loading branch information
Bryan C. Mills committed May 4, 2023
1 parent ca49b8d commit dcd1c31
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/runtime/crash_cgo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,10 @@ func TestSegv(t *testing.T) {
}

t.Run(test, func(t *testing.T) {
if test == "SegvInCgo" && runtime.GOOS == "ios" {
testenv.SkipFlaky(t, 59947) // Don't even try, in case it times out.
}

t.Parallel()
got := runTestProg(t, "testprogcgo", test)
t.Log(got)
Expand Down

0 comments on commit dcd1c31

Please sign in to comment.