This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Clarify when to run ensure when vendor is not committed #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after a rebase. |
ibrasho
reviewed
Sep 9, 2017
docs/FAQ.md
Outdated
|
|
||
| **Cons** | ||
|
|
||
| - your repo will be bigger, potentially a lot bigger | ||
| - PR diffs are more annoying | ||
| - Your repo will be bigger, potentially a lot bigger. Pruning can help minimize this problem. |
There was a problem hiding this comment.
Minor nit:
Let's remove "Pruning can help minimize this problem." when prune is merged into ensure. Since it will feel like an additional step is required to have that benefit.
carolynvs
force-pushed
the
commit-vendor-faq
branch
3 times, most recently
from
60b4442 to
a36e40d
Compare
carolynvs
force-pushed
the
commit-vendor-faq
branch
from
a36e40d to
01d6b3a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
The current FAQ is misleading. When you don't commit vendor, you must run
depensure after most git operations, not just a fresh clone. Otherwise you will have an out-of-datevendor/whenever someone updates the Gopkg.lock.Honestly, based on this, I have now completely flipped positions on committing vendor, and tell everyone who asks "Yes, commit it!" 😀
What should your reviewer look out for in this PR?
Let me know if I'm totally misunderstanding when you have to run dep ensure if you don't commit vendor.
Do you need help or clarification on anything?
Nope.