remove support for Go <= 1.14 #28
Conversation
|
If we decide to do this, I would suggest having a clear notice about this in the README, since we are currently not able to go the Probably it would also good to add a sentence or two in the version history that v3.2.1 will be the last release supporting Go 1.14 and below |
There was a problem hiding this comment.
Only minor things like spelling need to be change please, Could you also maybe drop a hint in the VERSION_HISTORY.md about the v3.2.1 being the last version that supports Go <= 1.14? Otherwise, I will do that in a follow-up commit.
Apart from that, let's see what others think @mfridman, @Waterdrips
As far as I could gather from the other conversation, @ripienaar was already in favour of this approach.
README.md
Outdated
| So we will support a major version of Go until there are two newer major releases. | ||
| We no longer support building jwt-go with unsupported Go versions, as these contain security vulnerabilities | ||
| which will not be fixed. | ||
| This means that currently we support Go 1.15 and 1.16. |
There was a problem hiding this comment.
We might drop the specific statement of 1.15 and 1.16 here else we end up having to always remember to update this - which we probably wont :)
Otherwise LGTM
Go 1.14 and below are no longer supported by the toolchain and standard libraries and no longer provide security updates.
See #29