Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite loop when using on-quit #1856

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

joelim-work
Copy link
Collaborator

To reproduce, use the following config, start lf and then close the terminal window:

cmd on-quit ${{
    notify-send foo
    sleep 1
}}

Because the terminal is already closed, running on-quit as a synchronous shell command will cause app.quit to be called again, forming an infinite loop.

@joelim-work joelim-work merged commit 68a29c9 into gokcehan:master Nov 17, 2024
4 checks passed
@joelim-work joelim-work deleted the quit-patch branch November 17, 2024 12:10
@joelim-work joelim-work added the fix Pull requests that fix existing behavior label Nov 17, 2024
@joelim-work joelim-work added this to the r34 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix existing behavior
Projects
None yet
1 participant