Remove environment exports from preview thread #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokcehan
approved these changes
Jul 26, 2023
gokcehan
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Export user-options when they are evaluated If one has an external previewer that uses an lf user-option (e.g. "preview-mode") and some key-kindings that change this user-option (e.g. to "hex", "simple", "fancy") and send a "reload" command to lf, then the expectation after pressing the keys is, that the prewiever is called with an updated value of the user-option. Though this did not happen since #1354, as this caused random crashes. This change exports user-defined options immediately when they are evaluated. * Fix: Add explaining comment
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixeslater)Pass the next file to be previewed directly to the
cleanerprogram instead of using environment variable exports, which is not thread-safe. This can be accessed using$6instead of$f, should be labelled as a breaking change.Exporting the options is also removed - the initial motivation was to use the
ratiossetting to determine the width of the preview, see #468 for more details. At that time, only the height was passed to thepreviewerprogram, see the diff. However this is no longer required as the preview dimensions are now passed as of #531.