Update file info after reload command #1149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
To reproduce the issue:
lf
and select a filechmod
to change the file permissionslf
and run thereload
commandThe current behaviour is that although
reload
does load the new file info (asynchronously), it isn't displayed because of the following condition:lf/app.go
Lines 417 to 419 in 3fc1db5
It turns out that this code was added to display the file info when starting up, see #994. So just after the
reload
command, I clearapp.ui.msg
to create a similar situation.I also considered just removing the
if app.ui.msg == ""
condition during the asynchronous reload, but that could cause issues like clearing out error messages at unexpected times.