Normalize host and path in cloudfront storage get #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajatprabha
approved these changes
Aug 9, 2019
| @@ -7,7 +7,7 @@ import ( | |||
| // Option represents the Cloudfront storage options | |||
| type Option func(s *Storage) | |||
|
|
|||
| // WithCloudfrontHost sets the cloudfront URL | |||
| // WithCloudfrontHost sets the cloudfront host, can ends up with trailing slash or not | |||
There was a problem hiding this comment.
lol you are right, thanks for the correction
| @@ -12,15 +12,15 @@ import ( | |||
|
|
|||
| // Storage holds the fields used by cloudfront storage implementation | |||
| type Storage struct { | |||
| cloudfrontHost string | |||
| cloudfrontHost string // can ends with trailing slash or not (example: "localhost:8000", "localhost:8000/") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.