Return error in case of failure during registering statsd collector f…

…or hystrix metrics
gojek · Jul 30, 2019 · f91bcfb · f91bcfb
1 parent f9e41ff
commit f91bcfb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pkg/metrics/statsd_collector.go b/pkg/metrics/statsd_collector.go
@@ -60,10 +60,14 @@ func InitializeStatsdCollector(config *StatsdCollectorConfig) error {
 }
 
 func RegisterHystrixMetrics(config *StatsdCollectorConfig, prefix string) error {
-	c, _ := plugins.InitializeStatsdCollector(&plugins.StatsdCollectorConfig{
+	c, err := plugins.InitializeStatsdCollector(&plugins.StatsdCollectorConfig{
 		StatsdAddr: config.StatsdAddr,
 		Prefix:     prefix,
 	})
+	if err != nil {
+		logger.Errorf("failed to initialize statsd collector for hystrix metrics with error: %s", err.Error())
+		return err
+	}
 	metricCollector.Registry.Register(c.NewStatsdCollector)
 	return nil
 }

diff --git a/pkg/metrics/statsd_collector_test.go b/pkg/metrics/statsd_collector_test.go
@@ -31,6 +31,11 @@ func TestInitializeStatsdCollector(t *testing.T) {
 func TestRegisterHystrixMetrics(t *testing.T) {
 	err := RegisterHystrixMetrics(&StatsdCollectorConfig{}, "prefix")
 	assert.Nil(t, err)
+
+	err = RegisterHystrixMetrics(&StatsdCollectorConfig{
+		StatsdAddr: "foo:bar:foo",
+	}, "prefix")
+	assert.NotNil(t, err)
 }
 
 func TestUpdate(t *testing.T) {