Merge pull request #38 from baskarap/master

Resize the image in case of cropping request does NOT pass one of w/h

pkg/processor/native/processor.go

@@ -28,6 +28,13 @@ type ProcessorOption func(*BildProcessor)
 
 // Crop takes an input image, width, height and a CropPoint and returns the cropped image
 func (bp *BildProcessor) Crop(img image.Image, width, height int, point processor.CropPoint) image.Image {
+	if width == 0 || height == 0 {
+		if width == 0 && height == 0 {
+			return img
+		}
+		return bp.Resize(img, width, height)
+	}
+
 	w, h := getResizeWidthAndHeightForCrop(width, height, img.Bounds().Dx(), img.Bounds().Dy())
 	img = transform.Resize(img, w, h, transform.Linear)
 	x0, y0 := getStartingPointForCrop(w, h, width, height, point)

pkg/processor/native/processor_test.go

@@ -51,12 +51,45 @@ func (s *BildProcessorSuite) TestBildProcessor_ResizeWithSameWidthAndHeight() {
 }
 
 func (s *BildProcessorSuite) TestBildProcessor_Crop() {
-	out := s.processor.Crop(s.srcImage, 500, 500, processor.CropCenter)
+	cases := []struct {
+		w         int
+		h         int
+		expectedW int
+		expectedH int
+	}{
+		{
+			w:         500,
+			h:         500,
+			expectedW: 500,
+			expectedH: 500,
+		},
+		{
+			w:         500,
+			h:         0,
+			expectedW: 500,
+			expectedH: 375,
+		},
+		{
+			w:         0,
+			h:         500,
+			expectedW: 666,
+			expectedH: 500,
+		},
+		{
+			w:         0,
+			h:         0,
+			expectedW: 500,
+			expectedH: 375,
+		},
+	}
+	for _, c := range cases {
+		out := s.processor.Crop(s.srcImage, c.w, c.h, processor.CropCenter)
 
-	assert.NotNil(s.T(), out)
+		assert.NotNil(s.T(), out)
 
-	assert.Equal(s.T(), 500, out.Bounds().Dx())
-	assert.Equal(s.T(), 500, out.Bounds().Dy())
+		assert.Equal(s.T(), c.expectedW, out.Bounds().Dx())
+		assert.Equal(s.T(), c.expectedH, out.Bounds().Dy())
+	}
 }
 
 func (s *BildProcessorSuite) TestBildProcessor_Grayscale() {