removes duplication in test code

gojek · Jul 23, 2019 · 03bc3b8 · 03bc3b8
1 parent e92be34
commit 03bc3b8
Showing 1 changed file with 56 additions and 52 deletions.
diff --git a/pkg/processor/native/processor_test.go b/pkg/processor/native/processor_test.go
@@ -66,63 +66,67 @@ func (s *BildProcessorSuite) TestBildProcessor_Grayscale() {
 func (s *BildProcessorSuite) TestBildProcessor_Flip() {
 	var actual, expected []byte
 	var err error
-	out := s.processor.Flip(s.srcImage, "v")
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_flipedV.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
-
-	out = s.processor.Flip(s.srcImage, "h")
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_flipedH.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
-
-	out = s.processor.Flip(s.srcImage, "vh")
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_flipedVH.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
+	cases := []struct {
+		flipMode string
+		testFile string
+	}{
+		{
+			flipMode: "v",
+			testFile: "_testdata/test_flipedV.jpg",
+		},
+		{
+			flipMode: "h",
+			testFile: "_testdata/test_flipedH.jpg",
+		},
+		{
+			flipMode: "vh",
+			testFile: "_testdata/test_flipedVH.jpg",
+		},
+	}
+
+	for _, c := range cases {
+		out := s.processor.Flip(s.srcImage, c.flipMode)
+		actual, err = s.processor.Encode(out, "jpeg")
+		assert.NotNil(s.T(), actual)
+		assert.Nil(s.T(), err)
+		expected, err = ioutil.ReadFile(c.testFile)
+		assert.NotNil(s.T(), expected)
+		assert.Nil(s.T(), err)
+		assert.EqualValues(s.T(), actual, expected)
+	}
 }
 
 func (s *BildProcessorSuite) TestBildProcessor_Rotate() {
 	var actual, expected []byte
 	var err error
-	out := s.processor.Rotate(s.srcImage, 90)
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_rotated90.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
-
-	out = s.processor.Rotate(s.srcImage, 175)
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_rotated175.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
-
-	out = s.processor.Rotate(s.srcImage, 450)
-	actual, err = s.processor.Encode(out, "jpeg")
-	assert.NotNil(s.T(), actual)
-	assert.Nil(s.T(), err)
-	expected, err = ioutil.ReadFile("_testdata/test_rotated90.jpg")
-	assert.NotNil(s.T(), expected)
-	assert.Nil(s.T(), err)
-	assert.EqualValues(s.T(), actual, expected)
+	cases := []struct {
+		angle    float64
+		testFile string
+	}{
+		{
+			angle:    90.0,
+			testFile: "_testdata/test_rotated90.jpg",
+		},
+		{
+			angle:    175,
+			testFile: "_testdata/test_rotated175.jpg",
+		},
+		{
+			angle:    450.0,
+			testFile: "_testdata/test_rotated90.jpg",
+		},
+	}
+
+	for _, c := range cases {
+		out := s.processor.Rotate(s.srcImage, c.angle)
+		actual, err = s.processor.Encode(out, "jpeg")
+		assert.NotNil(s.T(), actual)
+		assert.Nil(s.T(), err)
+		expected, err = ioutil.ReadFile(c.testFile)
+		assert.NotNil(s.T(), expected)
+		assert.Nil(s.T(), err)
+		assert.EqualValues(s.T(), actual, expected)
+	}
 }
 
 func (s *BildProcessorSuite) TestBildProcessor_Watermark() {