feat: add :contentbasename permalink token #13382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
commented
Feb 12, 2025
resources/page/permalinks_test.go
Outdated
Comment on lines
49
to
50
| {"/:contentbasename/", true, "/index/"}, // Content base name | ||
| {"/:contentbasenameorslug/", true, "/index/"}, // Content base name or slug |
There was a problem hiding this comment.
I noticed that, for the test files, the component is not defined for paths, meaning that here we just get the filename (without extension) instead of the parent file's name as we'd get inside the content directory.
hacdias
force-pushed
the
feat/add-contentbasename-token
branch
2 times, most recently
from
cfc6d65 to
5c0cbfe
Compare
|
Tests seem to be failing with unrelated errors:
|
bep
force-pushed
the
feat/add-contentbasename-token
branch
from
5c0cbfe to
0700e01
Compare
`:contentbasename`: 1. ContentBaseName 2. Slug or title `:slugorcontentbasename`: 1. Slug 2. ContentBaseName 3. Title Closes #11722
bep
force-pushed
the
feat/add-contentbasename-token
branch
from
0700e01 to
241a9f7
Compare
`:contentbasename`: 1. ContentBaseName 2. Slug or title `:slugorcontentbasename`: 1. Slug 2. ContentBaseName 3. Title Closes #11722
|
I will wrap this up in #/13402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes described in #11722 (comment), except for the deprecation of
:filename.