Add codespell support (config, workflow to detect/not fix) and make it fix few typos #12731
Conversation
|
|
|
Thanks for this. I will consider this if you provide a PR with only the GitHub action related files. As you may notice, there are build failures, but please don't try to fix those, just adjust the PR content. |
|
I am sorry -- do you mean to not include typo fixes codespell did? should they go into a separate PR? |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
403d6b9 to
7321c02
Compare
|
meanwhile I have signed SLA, rebased, redid codespell fixes with newer codespell (to address conflict + account new found on CI but not locally typo), and fixed indentation after codespell fix which lead to some linting CI jobs to fail. |
|
You need to include the config setup ONLY. Don't run it. |
|
I'm closing this for now. This may be interesting some time in the future, but as for now it creates too much noise. |
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.