Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS env override of nested param in theme does not work #8346

Closed
bep opened this issue Mar 19, 2021 · 1 comment · Fixed by #8349
Closed

OS env override of nested param in theme does not work #8346

bep opened this issue Mar 19, 2021 · 1 comment · Fixed by #8349
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.82

Comments

@bep
Copy link
Member

bep commented Mar 19, 2021

I may be wrong here (because I suspected this to just work).
@bep bep added the Bug label Mar 19, 2021
@bep bep added this to the v0.81.1 milestone Mar 19, 2021
@bep bep self-assigned this Mar 19, 2021
@bep bep changed the title Setting config from env (e.g. HUGO_PARAMS_MYPARAM) does not overwrite params defined in theme modules Setting config from env (e.g. HUGO_PARAMS_MYPARAM)?? Mar 19, 2021
bep added a commit to bep/hugo that referenced this issue Mar 20, 2021
@bep
Fix OS env override for nested section only available in theme
24297c4 
Fixes gohugoio#8346
@bep bep mentioned this issue Mar 20, 2021
Merged
@bep bep changed the title Setting config from env (e.g. HUGO_PARAMS_MYPARAM)?? OS env override of nested param in theme does not work Mar 20, 2021
bep added a commit to bep/hugo that referenced this issue Mar 20, 2021
@bep
Fix OS env override for nested config param only available in theme
3e60726 
Fixes gohugoio#8346
@bep bep closed this as completed in #8349 Mar 20, 2021
bep added a commit that referenced this issue Mar 20, 2021
@bep
Fix OS env override for nested config param only available in theme
7ed56c6 
Fixes #8346
bep added a commit that referenced this issue Mar 21, 2021
@bep
Apply OS env overrides twice
fc06e85 
The recent fix for #8346 had an unfortunate side-effect, as it prevented overrides of config options used in the module collector, e.g. `HUGO_MODULE_REPLACEMENTS`.

This commit fixes that by applying the overrides twice.
@bep bep modified the milestones: v0.81.1, v0.82 Mar 21, 2021
@bot-actions bot-actions bot mentioned this issue Mar 22, 2021
Merged
@gofish-bot gofish-bot mentioned this issue Mar 22, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.82
Development

Successfully merging a pull request may close this issue.

Fix OS env override for nested section only available in theme bep/hugo
1 participant
@bep