perf: listAuthorizedProjectIDs should not get metadata #21555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Metadata Signed-off-by: 曹阳兴 <[email protected]>
wy65701436
reviewed
Feb 11, 2025
| @@ -153,7 +153,7 @@ func (r *repositoryAPI) listAuthorizedProjectIDs(ctx context.Context) ([]int64, | |||
| query.Keywords["public"] = true | |||
| } | |||
|
|
|||
| projects, err := r.proCtl.List(ctx, query) | |||
| projects, err := r.proCtl.List(ctx, query, project.Detail(false)) | |||
There was a problem hiding this comment.
we can also set the WithMetadata to false.
There was a problem hiding this comment.
I think project.Detail(false) has set WithMetadata to false. But the explicit assignment is also OK
harbor/src/controller/project/controller.go
Line 254 in 490f898
|
@Czoyx Thanks for catching that, could you also provide the performance comparison for reference? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21555 +/- ##
==========================================
+ Coverage 45.36% 46.26% +0.89%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6423 +374
- Misses 6983 7122 +139
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ListRepositoriesinterface was taking excessively long to execute. The root cause was thatlistAuthorizedProjectIDswas fetching unnecessary metadata. This PR removes the metadata retrieval from listAuthorizedProjectIDs, thereby improving the overall performance of the interface.Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: