-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Overflow in Interrogation Services Page #21043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21043 +/- ##
==========================================
+ Coverage 45.36% 46.17% +0.80%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6410 +361
- Misses 6983 7135 +152
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are already on it @bupd
having a fully vertical alignment (instead of a mix between both) is probably a better option.
7e586cb
to
1e2a9c8
Compare
@bupd can you add yet another screenshot |
Sure, @Vad1mo Screenshot |
Signed-off-by: bupd <[email protected]>
* adds padding in between scan now and results of the scan Signed-off-by: bupd <[email protected]>
1e2a9c8
to
6f4796a
Compare
This PR is completed and is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
flaky tests. re-running the tests would fix it. |
Summary
Before Fix
on screen 1280x720
![before vuln ui fix](https://private-user-images.githubusercontent.com/89722848/376339430-3c215396-5138-4a88-8420-1f556fa93010.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjAxMDMsIm5iZiI6MTczOTM1OTgwMywicGF0aCI6Ii84OTcyMjg0OC8zNzYzMzk0MzAtM2MyMTUzOTYtNTEzOC00YTg4LTg0MjAtMWY1NTZmYTkzMDEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMzAwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3NjI5YWU3MjdmZWE0MmI1ZTM2NDliYWQ2MzQ5OTMxNTU0ZTY5YzQ5MWM1NWM4ZTQ1OTUyYmE3NzJjMzMyYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xu78c_SP7KJFuf2oCq3Sz8XXA8eyQZESGpzchsDZlLo)
After Fix
on screen 1280x720
![fix ui 21043](https://private-user-images.githubusercontent.com/89722848/377586110-916c7cee-b735-4c82-9ff3-a36291b2019b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjAxMDMsIm5iZiI6MTczOTM1OTgwMywicGF0aCI6Ii84OTcyMjg0OC8zNzc1ODYxMTAtOTE2YzdjZWUtYjczNS00YzgyLTlmZjMtYTM2MjkxYjIwMTliLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMzAwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI1NTcxNzY0ZTA3YjM5ZTcxZjU0Y2FhZTM2Y2QwMTVmMWUwOGVhZmQzZWEwMzI2NDcyNzZmOGEzMjNlNTdhOTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VTfH9LAz_fMY0ENxcmuIwtHjkjMiLF7ymLO0otBXq2U)
Issue being fixed
Fixes #20818
Please indicate you've done the following: