-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix robot account access issue #19627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19627 +/- ##
==========================================
+ Coverage 67.51% 67.55% +0.03%
==========================================
Files 991 991
Lines 109167 109168 +1
Branches 2719 2719
==========================================
+ Hits 73699 73743 +44
+ Misses 31497 31453 -44
- Partials 3971 3972 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
force-pushed
the
robot-sys-issue
branch
from
November 27, 2023 10:19
0ad10c9
to
7a145dd
Compare
fixes goharbor#19622 Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources. Signed-off-by: wang yan <[email protected]>
wy65701436
force-pushed
the
robot-sys-issue
branch
from
November 27, 2023 10:21
f82eaa7
to
65891e3
Compare
AllForNothing
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
stonezdj
approved these changes
Nov 27, 2023
OrlinVasilev
approved these changes
Nov 27, 2023
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
fixes goharbor#19622 Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources. Signed-off-by: wang yan <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19622
Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: